New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser display settings + refactoring #80

Merged

Colin-b merged 35 commits into develop from feature/custom_templates

Feb 18, 2024

Owner

Colin-b commented Feb 18, 2024

No description provided.

Colin-b and others added 30 commits

February 12, 2024 01:22


          Merge pull request #79 from Colin-b/develop

Release 0.20.0


          Allow users to override authentication code success/failure templates

43aeca8


          Add tests for custom auth code templates

a31104c


          Fix default authorization code success/failure templates

67797d1


          Merge pull request #74 from blag/custom-auth-code-templates

8a1abd7


          Merge remote-tracking branch 'origin/master' into feature/custom_temp…

75a24fe

…lates


          Add more type hinting to multi auth

5d97f4b


          Expose multi auth

c757257


          More control over publicly exposed information

64a4969


          More control over publicly exposed information

201166a


          Cannot use Self for now

cc6359a


          split authorization code / pkce

569e056


          Publicly expose the token memory cache

ae48e0d


          cleanup import

3e140a4


          cleanup import (this one should not be done anyway, we should refacto…

1e7f0bb

…r this)


          patch the new location of implicit uuid

391de12


          Patch the new location of auth code pkce random

7ecd221


          Add the remaining missing imports

3acd1dd


          Keep number of test cases up to date

a757c16


          Allow to tweak display

8bbb8f5


          document the new parameters in changelog as well

b7754e2


          Set the template via the settings

213f9bb


          draft of the new templates

1810ed9


          draft of the new templates

d485214


          Handle format

34b42ee


          Update remaining tests

f2a8f2d


          Update remaining tests

c850cfa


          Add template tests

885d3ae


          Add template tests

6a550de


          Add template tests

b2709f8

Colin-b added 5 commits

February 18, 2024 13:37


          Rename custom html

d49e375


          Document usage with boto

17efead


          Use renamed parameter

8a45712


          Reflect the new timeout in tests

cf40285


          scope is now mandatory for okta client credentials flow

4719fbc

Colin-b merged commit 7c72e2f into develop

8 checks passed

Colin-b deleted the feature/custom_templates branch

February 18, 2024 14:16

sonarqubecloud bot commented Feb 18, 2024

Quality Gate failed

Failed conditions
20.5% Duplication on New Code (required ≤ 3%)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

github-advanced-security bot found potential problems

View reviewed changes

tests/oauth2/authorization_code/wakatime/test_oauth2_authorization_code_wakatime_async.py

+              ):
+                  auth = httpx_auth.WakaTimeAuthorizationCode(
+                      "jPJQV0op6Pu3b66MWDi8b1wD",
+                      "waka_sec_0c4MBGeR9LN74LzV5uelF9SgeQ32CqfeWpIuieneBbsL57dAAlqqJWDiVDJOlsSx61pVwHMKlsb3uMvU",

Check failure

Code scanning / SonarCloud

WakaTime tokens should not be disclosed High test

Make sure this WakaTime OAuth secret gets revoked, changed, and removed from the code. See more on SonarCloud

tests/oauth2/authorization_code/wakatime/test_oauth2_authorization_code_wakatime_async.py

+                      "<body><div>SUCCESS: {display_time}</div></body>"
+                  )
+                  tab = browser_mock.add_response(
+                      opened_url="https://wakatime.com/oauth/authorize?client_id=jPJQV0op6Pu3b66MWDi8b1wD&client_secret=waka_sec_0c4MBGeR9LN74LzV5uelF9SgeQ32CqfeWpIuieneBbsL57dAAlqqJWDiVDJOlsSx61pVwHMKlsb3uMvU&scope=email&response_type=code&state=5d0adb208bdbecaf5cfb6de0bf4ba0aea52986f3fc5ea7bc30c4b2db449c17e5c9d15f9a3926476cdaf1c72e9f73c7cfdc624dde0187c38d8c6b04532770df2a&redirect_uri=http%3A%2F%2Flocalhost%3A5000%2F",

Check failure

Code scanning / SonarCloud

WakaTime tokens should not be disclosed High test

Make sure this WakaTime OAuth secret gets revoked, changed, and removed from the code. See more on SonarCloud

tests/oauth2/authorization_code/wakatime/test_oauth2_authorization_code_wakatime_async.py

+                      method="POST",
+                      url="https://wakatime.com/oauth/token",
+                      html="access_token=waka_tok_12345&token_type=bearer&expires_in=3600&refresh_token=waka_ref_12345&scope=email&example_parameter=example_value",
+                      match_content=b"grant_type=authorization_code&redirect_uri=http%3A%2F%2Flocalhost%3A5000%2F&client_id=jPJQV0op6Pu3b66MWDi8b1wD&client_secret=waka_sec_0c4MBGeR9LN74LzV5uelF9SgeQ32CqfeWpIuieneBbsL57dAAlqqJWDiVDJOlsSx61pVwHMKlsb3uMvU&scope=email&response_type=code&code=SplxlOBeZQQYbYS6WxSbIA",

Check failure

Code scanning / SonarCloud

WakaTime tokens should not be disclosed High test

Make sure this WakaTime OAuth secret gets revoked, changed, and removed from the code. See more on SonarCloud

tests/oauth2/authorization_code/wakatime/test_oauth2_authorization_code_wakatime_async.py

+              ):
+                  auth = httpx_auth.WakaTimeAuthorizationCode(
+                      "jPJQV0op6Pu3b66MWDi8b1wD",
+                      "waka_sec_0c4MBGeR9LN74LzV5uelF9SgeQ32CqfeWpIuieneBbsL57dAAlqqJWDiVDJOlsSx61pVwHMKlsb3uMvU",

Check failure

Code scanning / SonarCloud

WakaTime tokens should not be disclosed High test

Make sure this WakaTime OAuth secret gets revoked, changed, and removed from the code. See more on SonarCloud

tests/oauth2/authorization_code/wakatime/test_oauth2_authorization_code_wakatime_async.py

+                  )
+                  httpx_auth.OAuth2.display.failure_html = "FAILURE: {display_time}\n{information}"
+                  tab = browser_mock.add_response(
+                      opened_url="https://wakatime.com/oauth/authorize?client_id=jPJQV0op6Pu3b66MWDi8b1wD&client_secret=waka_sec_0c4MBGeR9LN74LzV5uelF9SgeQ32CqfeWpIuieneBbsL57dAAlqqJWDiVDJOlsSx61pVwHMKlsb3uMvU&scope=email&response_type=code&state=5d0adb208bdbecaf5cfb6de0bf4ba0aea52986f3fc5ea7bc30c4b2db449c17e5c9d15f9a3926476cdaf1c72e9f73c7cfdc624dde0187c38d8c6b04532770df2a&redirect_uri=http%3A%2F%2Flocalhost%3A5000%2F",

Check failure

Code scanning / SonarCloud

WakaTime tokens should not be disclosed High test

Make sure this WakaTime OAuth secret gets revoked, changed, and removed from the code. See more on SonarCloud

tests/oauth2/authorization_code/wakatime/test_oauth2_authorization_code_wakatime_sync.py

+              ):
+                  auth = httpx_auth.WakaTimeAuthorizationCode(
+                      "jPJQV0op6Pu3b66MWDi8b1wD",
+                      "waka_sec_0c4MBGeR9LN74LzV5uelF9SgeQ32CqfeWpIuieneBbsL57dAAlqqJWDiVDJOlsSx61pVwHMKlsb3uMvU",

Check failure

Code scanning / SonarCloud

WakaTime tokens should not be disclosed High test

Make sure this WakaTime OAuth secret gets revoked, changed, and removed from the code. See more on SonarCloud

tests/oauth2/authorization_code/wakatime/test_oauth2_authorization_code_wakatime_sync.py

+                      "<body><div>SUCCESS: {display_time}</div></body>"
+                  )
+                  tab = browser_mock.add_response(
+                      opened_url="https://wakatime.com/oauth/authorize?client_id=jPJQV0op6Pu3b66MWDi8b1wD&client_secret=waka_sec_0c4MBGeR9LN74LzV5uelF9SgeQ32CqfeWpIuieneBbsL57dAAlqqJWDiVDJOlsSx61pVwHMKlsb3uMvU&scope=email&response_type=code&state=5d0adb208bdbecaf5cfb6de0bf4ba0aea52986f3fc5ea7bc30c4b2db449c17e5c9d15f9a3926476cdaf1c72e9f73c7cfdc624dde0187c38d8c6b04532770df2a&redirect_uri=http%3A%2F%2Flocalhost%3A5000%2F",

Check failure

Code scanning / SonarCloud

WakaTime tokens should not be disclosed High test

Make sure this WakaTime OAuth secret gets revoked, changed, and removed from the code. See more on SonarCloud

tests/oauth2/authorization_code/wakatime/test_oauth2_authorization_code_wakatime_sync.py

+                      method="POST",
+                      url="https://wakatime.com/oauth/token",
+                      html="access_token=waka_tok_12345&token_type=bearer&expires_in=3600&refresh_token=waka_ref_12345&scope=email&example_parameter=example_value",
+                      match_content=b"grant_type=authorization_code&redirect_uri=http%3A%2F%2Flocalhost%3A5000%2F&client_id=jPJQV0op6Pu3b66MWDi8b1wD&client_secret=waka_sec_0c4MBGeR9LN74LzV5uelF9SgeQ32CqfeWpIuieneBbsL57dAAlqqJWDiVDJOlsSx61pVwHMKlsb3uMvU&scope=email&response_type=code&code=SplxlOBeZQQYbYS6WxSbIA",

Check failure

Code scanning / SonarCloud

WakaTime tokens should not be disclosed High test

Make sure this WakaTime OAuth secret gets revoked, changed, and removed from the code. See more on SonarCloud

tests/oauth2/authorization_code/wakatime/test_oauth2_authorization_code_wakatime_sync.py

+              ):
+                  auth = httpx_auth.WakaTimeAuthorizationCode(
+                      "jPJQV0op6Pu3b66MWDi8b1wD",
+                      "waka_sec_0c4MBGeR9LN74LzV5uelF9SgeQ32CqfeWpIuieneBbsL57dAAlqqJWDiVDJOlsSx61pVwHMKlsb3uMvU",

Check failure

Code scanning / SonarCloud

WakaTime tokens should not be disclosed High test

Make sure this WakaTime OAuth secret gets revoked, changed, and removed from the code. See more on SonarCloud

tests/oauth2/authorization_code/wakatime/test_oauth2_authorization_code_wakatime_sync.py

+                  )
+                  httpx_auth.OAuth2.display.failure_html = "FAILURE: {display_time}\n{information}"
+                  tab = browser_mock.add_response(
+                      opened_url="https://wakatime.com/oauth/authorize?client_id=jPJQV0op6Pu3b66MWDi8b1wD&client_secret=waka_sec_0c4MBGeR9LN74LzV5uelF9SgeQ32CqfeWpIuieneBbsL57dAAlqqJWDiVDJOlsSx61pVwHMKlsb3uMvU&scope=email&response_type=code&state=5d0adb208bdbecaf5cfb6de0bf4ba0aea52986f3fc5ea7bc30c4b2db449c17e5c9d15f9a3926476cdaf1c72e9f73c7cfdc624dde0187c38d8c6b04532770df2a&redirect_uri=http%3A%2F%2Flocalhost%3A5000%2F",

Check failure

Code scanning / SonarCloud

WakaTime tokens should not be disclosed High test

Make sure this WakaTime OAuth secret gets revoked, changed, and removed from the code. See more on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet