Migrate to basic models from freezed #372
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…logging-auth-repo fix: add manual logging to auth repo
Signed-off-by: Isaac Obella <[email protected]>
Signed-off-by: Isaac Obella <[email protected]>
Signed-off-by: Isaac Obella <[email protected]>
Signed-off-by: Isaac Obella <[email protected]>
Signed-off-by: Isaac Obella <[email protected]>
wizlif
force-pushed
the
ft/370/migrate-to-basic-models-from-freezed
branch
from
59229d8
to
7e0deee
Compare
Codecov Report
@@ Coverage Diff @@
## development #372 +/- ##
===============================================
- Coverage 66.55% 62.39% -4.16%
===============================================
Files 157 195 +38
Lines 4010 4851 +841
===============================================
+ Hits 2669 3027 +358
- Misses 1341 1824 +483
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Xazin
reviewed
Apr 1, 2023
| await _mapUpdateProfilePhotoToState(emit, event), | ||
| resendCode: (event) async => await _mapResendCodeToState(emit, event), | ||
| ); | ||
| if (event is _InitialEvent) { |
There was a problem hiding this comment.
This screams of Switch.
Maybe we can add a const to each event (parent class and need to override), eg.
const eventName = "SIGN_IN_WITH_PHONE";
| const factory AuthEvent.initial() = _InitialEvent; | ||
|
|
||
| const factory AuthEvent.verifyPhone(String phoneNumber) = _VerifyPhone; | ||
|
|
||
| const factory AuthEvent.updated( | ||
| Either<AuthFailure, AuthSuccess> failureOrCredential, | ||
| Either<AuthFailure, $auth_success.AuthSuccess> failureOrCredential, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Isaac Obella [email protected]