Issue #56: Drop the numeric error codes.

src/Cool/CollaboraDiscovery.php

@@ -47,18 +47,12 @@ public function getWopiClientURL(string $mimetype = 'text/plain'): string {
 
     $discovery_parsed = simplexml_load_string($xml);
     if (!$discovery_parsed) {
-      throw new CollaboraNotAvailableException(
-        'The retrieved discovery.xml file is not a valid XML file.',
-        102,
-      );
+      throw new CollaboraNotAvailableException('The retrieved discovery.xml file is not a valid XML file.');
     }
 
     $result = $discovery_parsed->xpath(sprintf('/wopi-discovery/net-zone/app[@name=\'%s\']/action', $mimetype));
     if (empty($result[0]['urlsrc'][0])) {
-      throw new CollaboraNotAvailableException(
-        'The requested mime type is not handled.',
-        103,
-      );
+      throw new CollaboraNotAvailableException('The requested mime type is not handled.');
     }
 
     return (string) $result[0]['urlsrc'][0];

src/Cool/CollaboraDiscoveryFetcher.php

@@ -74,8 +74,7 @@ public function getDiscoveryXml(): string {
       ]);
       throw new CollaboraNotAvailableException(
         'Not able to retrieve the discovery.xml file from the Collabora Online server.',
-        203,
-        $e,
+        previous: $e,
       );
     }
     return $xml;
@@ -95,21 +94,15 @@ protected function getWopiClientServerBaseUrl(): string {
     $cool_settings = $this->loadSettings();
     $wopi_client_server = $cool_settings['server'] ?? NULL;
     if (!$wopi_client_server) {
-      throw new CollaboraNotAvailableException(
-        'The configured Collabora Online server address is empty.',
-        201,
-      );
+      throw new CollaboraNotAvailableException('The configured Collabora Online server address is empty.');
     }
     $wopi_client_server = trim($wopi_client_server);
 
     if (!str_starts_with($wopi_client_server, 'http://') && !str_starts_with($wopi_client_server, 'https://')) {
-      throw new CollaboraNotAvailableException(
-        sprintf(
-          "The configured Collabora Online server address must begin with 'http://' or 'https://'. Found '%s'.",
-          $wopi_client_server,
-        ),
-        204,
-      );
+      throw new CollaboraNotAvailableException(sprintf(
+        "The configured Collabora Online server address must begin with 'http://' or 'https://'. Found '%s'.",
+        $wopi_client_server,
+      ));
     }
 
     return $wopi_client_server;

tests/src/ExistingSite/FetchClientUrlTest.php

@@ -51,7 +51,6 @@ public function testFetchClientUrlWithMisconfiguration(): void {
 
     $this->expectException(CollaboraNotAvailableException::class);
     $this->expectExceptionMessage("The configured Collabora Online server address must begin with 'http://' or 'https://'. Found 'httx://example.com'.");
-    $this->expectExceptionCode(204);
 
     $discovery->getWopiClientURL();
   }