Use a section and remove latlng and leaflet usage from impress&draw c… #10921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gokaysatir
force-pushed
the
private/gokay/latlng-4
branch
from
a400bca to
cbe5e98
Compare
gokaysatir
requested review from
eszkadev and
lpranam
and removed request for
eszkadev
gokaysatir
force-pushed
the
private/gokay/latlng-4
branch
2 times, most recently
from
6c6fa05 to
6b00b1f
Compare
|
Tests passed on local. |
…omments. Remove unused functions. Signed-off-by: Gökay Şatır <[email protected]> Change-Id: Id83eb01940d345b9954c441dd7cb0cff12516fa7
Don't use a section without adding it to the section container. Use app.map._docLayer instead of the local pointer. Signed-off-by: Gökay Şatır <[email protected]> Change-Id: I2b6cd88208677634004f50c5640318472b226f17
…rker. Signed-off-by: Gökay Şatır <[email protected]> Change-Id: I089b0d26164773ef752a2c106dc8295a737745b4
gokaysatir
force-pushed
the
private/gokay/latlng-4
branch
from
6b00b1f to
16e68a0
Compare
eszkadev
reviewed
Jan 20, 2025
| @@ -2375,7 +2375,7 @@ export class CommentSection extends app.definitions.canvasSectionObject { | |||
| if (this.sectionProperties.docLayer._docType === 'spreadsheet') | |||
| this.hideAllComments(); // Apply drawing orders. | |||
|
|
|||
| if (!(<any>window).mode.isMobile() && (this.sectionProperties.docLayer._docType === 'presentation' || this.sectionProperties.docLayer._docType === 'drawing')) | |||
There was a problem hiding this comment.
shouldn't be still non-mobile only? on mobile we have annotation mobile-wizard to manage comments
eszkadev
reviewed
Jan 20, 2025
| @@ -119,7 +119,7 @@ export class CommentSection extends app.definitions.canvasSectionObject { | |||
| this.sectionProperties.showSelectedBigger = false; | |||
| this.sectionProperties.calcCurrentComment = null; // We don't automatically show a Calc comment when cursor is on its cell. But we remember it to show if user presses Alt+C keys. | |||
| // This (commentsAreListed) variable means that comments are shown as a list on the right side of the document. | |||
| this.sectionProperties.commentsAreListed = (this.sectionProperties.docLayer._docType === 'text' || this.sectionProperties.docLayer._docType === 'presentation' || this.sectionProperties.docLayer._docType === 'drawing') && !(<any>window).mode.isMobile(); | |||
| this.sectionProperties.commentsAreListed = (app.map._docLayer._docType === 'text' || app.map._docLayer._docType === 'presentation' || app.map._docLayer._docType === 'drawing') && !(<any>window).mode.isMobile(); | |||
There was a problem hiding this comment.
does the app.map contain now a correct refrerence? in the past I always saw null there
|
I added my UI/UX comment for future: #10964 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…omments.
Change-Id: Id83eb01940d345b9954c441dd7cb0cff12516fa7
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay