-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keycode rewrite #53
Merged
Merged
keycode rewrite #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exists in order organize my thoughts for the rewrite, allow for public comments and transparency, and to allow me to work on this change synchronously with other updates.
Brief explanation:
Scancodes are codes from key input which refer to the actual physical key that is pressed.
For example, Q may be referred to as
21
being the 1st key on the 2nd row. (Note: this number is not based on how scancodes work in real life, but only for an example) That key can then be mapped by software such as SDL or RGFW to a standard key format such as QWERTY. Allowing you to useKEY_Q
to refer to the 1st key on the 2nd row no matter which keyboard you use. On a French Keyboard, that key would beKEY_A
, however the scancode would still beKEY_Q
Keycodes are mapped codes from key input. They are mapped by the OS based on the keyboard's set format. For example, with the French keyboard, when the A key is pressed, the keycode would be
KEY_A
.Scancodes are based on key placement, making them good for controls;
keycodes are based on key mapping, making them good for text input.
Currently, RGFW does not have any special sort of API for keycodes and scancodes. It was not designed with this difference in mind, which results in a few API flaws:
linux:
event.keycode -> scancode,
event.keyname -> keycode
windows:
event.keycode -> keycode,
event.keyname -> keycode
macOS:
event.keycode -> scancode
event.keyname -> keycode
web:
event.keycode -> keycode
event.keyname -> keycode
Features to implement: