Sensor support #16
Open
Sensor support #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpanic
reviewed
Aug 5, 2018
| sensorList := map[string]Sensor{} | ||
| err = json.Unmarshal(body, &sensorList) | ||
| if err != nil { | ||
| fmt.Print(err) |
There was a problem hiding this comment.
Printing the error is probably not what should be done by default, just returning it should be fine. Maybe include it in the errors.New() below.
| /* | ||
| * sensor.go | ||
| * GoHue library for Philips Hue | ||
| * Copyright (C) 2016 Collin Guarino (Collinux) [email protected] |
There was a problem hiding this comment.
This is a new file, so you probably can have your own copyright information here. At least the year should be current.
|
Any change of merging this? I need the sensor temperatures :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #13 but adds support for motion sensors and generic sensors.
Verified against Hue Bridge Daylight Sensor, Hue Dimmer Switch, Hue Tap Switch, Hue Motion Sensor and API-created sensors.