-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: wrap fit result in class #254
Conversation
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
==========================================
- Coverage 81.17% 79.94% -1.24%
==========================================
Files 13 13
Lines 712 743 +31
Branches 119 124 +5
==========================================
+ Hits 578 594 +16
- Misses 96 111 +15
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more.
|
One thing that's still missing is the covariance matrix. We have to think about a data type for that though. |
So the way I see this PR now is that it only (1) replaces the Btw, the fact that the
|
Wrapped the optimize
dict
output in aFitResult
class. It's a rather simpleattr
data container that wraps what was previously in adict
form. Optimizer-specific info has been put under aspecifics
attribute.