feat: 1878 copy cell lines #1923
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
app/usecases/cell_lines/copy.rb
Outdated
| end | ||
|
|
||
| def execute! | ||
| @current_user.increment_counter('celllines') # rubocop: disable Rails/SkipsModelValidations |
There was a problem hiding this comment.
Layout/ExtraSpacing: Unnecessary spacing detected.
soerenPeters
force-pushed
the
1878-copy-cell-lines
branch
from
b82e666 to
9bee601
Compare
FabianMauz
reviewed
May 16, 2024
| .then((result) => { | ||
| dispatch(result); | ||
| }).catch((errorMessage) => { | ||
| console.log(errorMessage); |
There was a problem hiding this comment.
I think we should add a response to the user that something went wrong
There was a problem hiding this comment.
Is this an error that can occur normally or should it not actually fail? In the latter case, I think that logging is enough. Especially since all other operations in the ElementAction only log to the console in the case of an error. What do you think?
|
Will be merged together with #1971. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #1878