ketcher2 User templates #1984
Closed
ketcher2 User templates #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` bin/ket2-install.sh ``` compatible version of ketcher 2 to install tracked in .service-dependencies
…lstorage in file format
…OFILES collection
LCOV of commit
|
LCOV of commit
|
…ublic/public_editor public/editors
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
app/api/chemotion/profile_api.rb
Outdated
|
|
||
| # remove file from store | ||
| file_path = Rails.root.join('uploads', Rails.env, params[:path]) | ||
| File.delete(file_path) if(File.exist?(file_path)) |
There was a problem hiding this comment.
Lint/NonAtomicFileOperation: Use atomic file operation method FileUtils.rm_f.
app/api/chemotion/profile_api.rb
Outdated
|
|
||
| # remove file from store | ||
| file_path = Rails.root.join('uploads', Rails.env, params[:path]) | ||
| File.delete(file_path) if(File.exist?(file_path)) |
There was a problem hiding this comment.
Layout/SpaceAroundKeyword: Space after keyword if is missing.
app/api/chemotion/profile_api.rb
Outdated
|
|
||
| # remove file from store | ||
| file_path = Rails.root.join('uploads', Rails.env, params[:path]) | ||
| File.delete(file_path) if(File.exist?(file_path)) |
There was a problem hiding this comment.
Lint/NonAtomicFileOperation: Remove unnecessary existence check File.exist?.
| requires :path, type: String, desc: 'file path of user template' | ||
| end | ||
| delete do | ||
| user_templates = current_user.profile.user_templates |
There was a problem hiding this comment.
Layout/IndentationWidth: Use 2 (not 0) spaces for indentation.
app/api/chemotion/profile_api.rb
Outdated
| new_profile) || error!('profile update failed', 500) | ||
|
|
||
| { status: true } | ||
| end |
There was a problem hiding this comment.
Layout/BlockAlignment: end at 207, 8 is not aligned with delete do at 191, 6.
|
|
||
| # remove file from store | ||
| file_path = Rails.root.join('uploads', Rails.env, params[:path]) | ||
| File.delete(file_path) if File.exist?(file_path) |
There was a problem hiding this comment.
Lint/NonAtomicFileOperation: Use atomic file operation method FileUtils.rm_f.
|
|
||
| # remove file from store | ||
| file_path = Rails.root.join('uploads', Rails.env, params[:path]) | ||
| File.delete(file_path) if File.exist?(file_path) |
There was a problem hiding this comment.
Lint/NonAtomicFileOperation: Remove unnecessary existence check File.exist?.
LCOV of commit
|
haditariq
changed the title
LCOV of commit
|
|
made redundant by #2061 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves Sub-feature (1.4) of Issue # 138:
User.template.feature.demo.1.mp4
rather 1-story 1-commit than sub-atomic commits
commit title is meaningful => git history search
commit description is helpful => helps the reviewer to understand the changes
code is up-to-date with the latest developments of the target branch (rebased to it or whatever) => ⏩-merge for linear history is favoured
added code is linted
tests are passing (at least locally): we still have some random test failure on CI. thinking of asking spec/examples.txt to be commited
in case the changes are visible to the end-user, video or screenshots should be added to the PR => helps with user testing
testing coverage improvement is improved.
CHANGELOG : add a bullet point on top (optional: reference to github issue/PR )
parallele PR for documentation on docusaurus if the feature/fix is tagged for a release