-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: development environment setup during the docker build process #2197
Open
Ramy-Badr-Ahmed
wants to merge
10
commits into
ComPlat:main
Choose a base branch
from
Ramy-Badr-Ahmed:setup-dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n before prepare-rubygems.sh. Created node_module directory as root then change ownership. Restyling Dockerfile.chemotion-dev file.
…. Added ruby scripts to .gitattributes.
Ramy-Badr-Ahmed
commented
Oct 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ramy-Badr-Ahmed
force-pushed
the
setup-dev
branch
from
October 5, 2024 19:15
a0b35bd
to
4e53ed5
Compare
…tarting the Rails server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements several improvements to the Chemotion ELN development environment for a dynamic build-up process:
Added database preparation script
prepare_database.sh
:database.yml
,shrine.yml
,storage.yml
,datacollectors.sh
), it prevents failures in therake db:setup
process.db:migrate:status
return fordown
.Added database migration step in
prepare-ruby-dev.sh
before starting the Rails server. This preventsActiveRecord::PendingMigrationError
due to pending migrations on server startup.Changes to
Dockerfile.chemotion-dev
:jq
.GEM
inPATH
.bundle
&gem
installation beforeprepare-rubygems.sh
.node_module
directory asroot
then changed ownership.Dockerfile.chemotion-dev
file.Shell Script Line Ending Management:
.gitattributes
file to enforceLF
line endings for shell scripts and .tool-versions (prevent issues withCRLF
line endings across different OS).docker-compose.dev.yml
to ensure shell scripts are checked and converted toLF
line endings before execution as expected by Docker.Changed
Webpacker
service to reference.env.development
instead of.env
Synchronise dynamically
engines.node
in package.json withREQUIRED_NODE_VERSION
to avoidyarn
failure duringjs
package installation.