Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: split cell line #2276

Merged
merged 1 commit into from
Jan 8, 2025
Merged

feat: split cell line #2276

merged 1 commit into from
Jan 8, 2025

Conversation

PiTrem
Copy link
Member

@PiTrem PiTrem commented Jan 8, 2025 •
edited
Loading

rebased
see #1971 for original PR review

feat: split cell lines

  • add split cell lines functionality
  • add split menu item for cell lines
  • calculate short label based on children
  • notification message after copy/split
  • create ancestry relationship
  • add ancestry gem functionality to cell lines
  • add ancestry column to cell lines
  • use-case for splitting cell lines
  • root container if not present after creation

refactor: moved message parameter to utils

@FabianMauz @PiTrem
commit a58a21f
0a06c3a 
Author: FabianMauz <[email protected]>
Date:   Wed Jun 12 08:06:13 2024 +0000

    chore: make rubocop happy

commit 1d37471
Author: FabianMauz <[email protected]>
Date:   Tue Jun 11 09:26:15 2024 +0000

    feat: add message after split

commit 96a3a2c
Author: FabianMauz <[email protected]>
Date:   Tue Jun 11 09:21:26 2024 +0000

    refactor: moved message parameter to utils

commit 9e2d849
Author: FabianMauz <[email protected]>
Date:   Mon Jun 10 14:01:46 2024 +0000

    feat: add message after  copy

commit 2d73ba7
Author: FabianMauz <[email protected]>
Date:   Mon Jun 10 13:45:57 2024 +0000

    fix: updating to latest counter information after cell line copy

commit b4f28aa
Author: FabianMauz <[email protected]>
Date:   Mon Jun 10 13:34:59 2024 +0000

    fix: update of cell line counter after creation of copy

commit c261471
Author: FabianMauz <[email protected]>
Date:   Mon Jun 10 12:13:58 2024 +0000

    feat: add split cell lines functionality

commit c6582ef
Author: FabianMauz <[email protected]>
Date:   Mon Jun 10 12:12:51 2024 +0000

    chore: fix wrong comment

commit 89abda3
Author: FabianMauz <[email protected]>
Date:   Mon Jun 10 12:12:08 2024 +0000

    fix: persist splitted cell line to save updated label

commit 3a399d4
Author: FabianMauz <[email protected]>
Date:   Mon Jun 10 11:12:40 2024 +0000

    feat: add split menu item for cell lines

commit 02c8b5b
Author: FabianMauz <[email protected]>
Date:   Fri May 31 12:28:32 2024 +0000

    feat: calculate short label based on children

commit b9d83fd
Author: FabianMauz <[email protected]>
Date:   Fri May 31 12:19:57 2024 +0000

    feat: create ancestry relationship

commit 24fc8ff
Author: FabianMauz <[email protected]>
Date:   Fri May 31 11:44:16 2024 +0000

    feat: add ancestry gem functionality to cell lines

commit 3001284
Author: FabianMauz <[email protected]>
Date:   Fri May 31 11:24:03 2024 +0000

    feat: add ancestry column to cell lines

commit cb0c48a
Author: FabianMauz <[email protected]>
Date:   Fri May 31 11:20:55 2024 +0000

    feat: add usecase for splitting cell lines

commit 50e58a2
Author: FabianMauz <[email protected]>
Date:   Fri May 31 09:42:16 2024 +0000

    test: add failing test for split cell line

commit aef1d29
Author: FabianMauz <[email protected]>
Date:   Fri May 31 09:19:17 2024 +0000

    feat: add root container if not present after creation

commit 0f1128d
Merge: 7639ad4 c6b6169
Author: FabianMauz <[email protected]>
Date:   Fri May 31 10:37:23 2024 +0200

    Merge remote-tracking branch 'refs/remotes/origin/main'

commit 7639ad4
Merge: b9bb1c2 27959e1
Author: Sören Peters <[email protected]>
Date:   Fri May 24 19:32:16 2024 +0000

    Merge remote-tracking branch 'origin/main' into 1878-copy-cell-lines

commit b9bb1c2
Author: Sören Peters <[email protected]>
Date:   Fri May 24 13:45:16 2024 +0000

    refactor: remove unnecessary space

commit b931b80
Merge: 7c2e475 4b2028c
Author: Sören Peters <[email protected]>
Date:   Fri May 24 13:42:16 2024 +0000

    Merge branch 'main' into 1878-copy-cell-lines

commit 7c2e475
Merge: 9bee601 6a2c85d
Author: Sören Peters <[email protected]>
Date:   Fri May 24 09:40:02 2024 +0000

    Merge branch 'main' into 1878-copy-cell-lines

commit 9bee601
Author: Sören Peters <[email protected]>
Date:   Thu May 16 10:29:06 2024 +0000

    chore: remove accidentally doubled changelog information

commit cc6997c
Merge: 8570333 a36ced3
Author: Sören Peters <[email protected]>
Date:   Thu May 16 10:23:23 2024 +0000

    Merge branch 'main' into 1878-copy-cell-lines

commit 8570333
Author: FabianMauz <[email protected]>
Date:   Tue May 7 13:53:09 2024 +0000

    feat: fixed element policy for cell lines

commit 44e95bc
Author: FabianMauz <[email protected]>
Date:   Tue May 7 11:23:36 2024 +0000

    feat: reenabled ElementPolicy check

commit c514055
Author: FabianMauz <[email protected]>
Date:   Tue May 7 11:07:58 2024 +0000

    refactor: extract api params to own file

commit cfb18f7
Author: FabianMauz <[email protected]>
Date:   Thu May 2 08:53:07 2024 +0000

    test: add container to spec

commit 9cb2796
Author: FabianMauz <[email protected]>
Date:   Tue Apr 30 12:13:27 2024 +0000

    feat: add container update/creation

commit aa460fe
Author: FabianMauz <[email protected]>
Date:   Tue Apr 30 12:12:32 2024 +0000

    feat: add frontend ui for creating cell lines

commit 4c302c9
Author: FabianMauz <[email protected]>
Date:   Mon Apr 29 13:43:31 2024 +0200

    merged with main

commit 9996875
Author: FabianMauz <[email protected]>
Date:   Mon Apr 29 11:38:44 2024 +0000

    feat: add links to collections of copied cell lines

commit 9cd9da9
Author: FabianMauz <[email protected]>
Date:   Mon Apr 29 11:09:47 2024 +0000

    feat: add rest endpoint for copy cell lines

commit 0a01175
Author: FabianMauz <[email protected]>
Date:   Mon Apr 29 08:02:35 2024 +0000

    feat: update short label and counter at copiing cell lines

commit 6bd053a
Author: FabianMauz <[email protected]>
Date:   Mon Apr 29 07:15:31 2024 +0000

    refactor: add loading to copy test

commit c51fe20
Author: Sören Peters <[email protected]>
Date:   Thu Apr 18 14:23:41 2024 +0000

    feat: create new cell_line with copied attributes

commit caf9b08
Author: Sören Peters <[email protected]>
Date:   Thu Apr 18 13:39:44 2024 +0000

    feat: create  empty CelllineSample when copy is executed.

commit af51e8e
Author: FabianMauz <[email protected]>
Date:   Thu Apr 18 11:49:54 2024 +0000

    feature: scaffhold of cell line sample copy created
@PiTrem PiTrem mentioned this pull request Jan 8, 2025
Closed
@PiTrem PiTrem linked an issue Jan 8, 2025 that may be closed by this pull request
Copy cell lines #1878
Closed
5 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

LCOV of commit 0a06c3a during Continuous Integration #4282

Summary coverage rate:
  lines......: 66.8% (14416 of 21569 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@PiTrem PiTrem merged commit 1fd2e42 into main Jan 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copy cell lines
2 participants
@PiTrem @FabianMauz