build(dev): docker compose using a prebuilt image with latest gems and node packages #2288
+182
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCOV of commit
|
PiTrem
force-pushed
the
dev-docker-compose
branch
2 times, most recently
from
46cebcc to
8c6122f
Compare
LCOV of commit
|
LCOV of commit
|
PiTrem
force-pushed
the
dev-docker-compose
branch
from
8c6122f to
d98b2f9
Compare
LCOV of commit
|
PiTrem
force-pushed
the
dev-docker-compose
branch
2 times, most recently
from
478d0d9 to
4899f89
Compare
LCOV of commit
|
LCOV of commit
|
PiTrem
force-pushed
the
dev-docker-compose
branch
from
4899f89 to
4a9a7d9
Compare
LCOV of commit
|
PiTrem
force-pushed
the
dev-docker-compose
branch
4 times, most recently
from
fc27fef to
f58f0bc
Compare
LCOV of commit
|
LCOV of commit
|
LCOV of commit
|
LCOV of commit
|
- set env variables in the docker-compose.dev.yml to allow using - prebuild images for the app and skip the building process - distinct postgres images - distinct named volume for the db and homedir(asdf, gems, etc) - add .dockerenv.example file to help settings those variables example ``` docker compose -f docker-compose.dev.yml --env-file .dockerenv.example up ``` - rework the preparation scripts to better separate node packages installation from ruby env installation. so that `yarn install` is only run by the js container - introduce FULL_BUILD BRANCH args for preparing the dev docker image with preinstalled gems and nodejs packages for a given branch from complat/chemotion_ELN - add optional var RAKE_DB_MIGRATE to run db:migrate instead of db:setup (see .dockerenv.example) - vs task to start docker compose with --env-file .dockerenv and without build
as prepare-ruby--dev is already called thr run-ruby
PiTrem
force-pushed
the
dev-docker-compose
branch
from
f58f0bc to
b6c4d24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set env variables in the docker-compose.dev.yml to allow using
add .dockerenv.example file to help settings those variables
example
rework the preparation scripts to better separate node packages
installation from ruby env installation. so that
yarn installis only run by the js container
introduce FULL_BUILD BRANCH args for preparing the dev docker
image with preinstalled gems and nodejs packages for a given
branch from complat/chemotion_ELN
(see .dockerenv.example)
NB the path for the node modules is set in the image outside the app directory to NODE_PATH