Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dell 7x0xd models #84

Merged
merged 5 commits into from
Jul 9, 2024
Merged

Support dell 7x0xd models #84

merged 5 commits into from
Jul 9, 2024

Conversation

ibrahimkk-moideen
Copy link
Collaborator

  1. 9ce9f66
    Flipped the endpoint places to capture all possible power and thermal components during metrics collection on Dell servers.

  2. a408408
    Certain FW versions, example ver.3.xx and 4.xx in Dell iDRAC9

  • Requires additional header "Accept: application/json" to be passed.
  • Doesn't support trailing "/" in firmware endpoints. To overcome this, included new "getFirmwareEndpoints" func to use the endpoints as received.

derrick-dacosta
derrick-dacosta approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@derrick-dacosta derrick-dacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@derrick-dacosta derrick-dacosta mentioned this pull request Jul 9, 2024
Closed
@ibrahimkk-moideen ibrahimkk-moideen merged commit ffc4a5a into main Jul 9, 2024
3 checks passed
@ibrahimkk-moideen ibrahimkk-moideen deleted the support_dell_7x0xd_models branch July 9, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrick-dacosta derrick-dacosta derrick-dacosta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibrahimkk-moideen @derrick-dacosta