Add waits

Comfy-Org · Jan 3, 2025 · b81d7d8 · b81d7d8
1 parent 55600d2
commit b81d7d8
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/browser_tests/fixtures/components/SidebarTab.ts b/browser_tests/fixtures/components/SidebarTab.ts
@@ -258,7 +258,7 @@ export class QueueSidebarTab extends SidebarTab {
   }
 
   getGalleryImage(imageFilename: string) {
-    return this.page.getByAltText(imageFilename).and(this.galleryImage)
+    return this.galleryImage.and(this.page.getByAltText(imageFilename))
   }
 
   getTaskImage(imageFilename: string) {

diff --git a/browser_tests/fixtures/utils/taskHistory.ts b/browser_tests/fixtures/utils/taskHistory.ts
@@ -135,8 +135,9 @@ export default class TaskHistory {
     this.tasks.unshift(task) // Tasks are added to the front of the queue
   }
 
-  clearTasks() {
+  clearTasks(): this {
     this.tasks = []
+    return this
   }
 
   withTask(

diff --git a/browser_tests/menu.spec.ts b/browser_tests/menu.spec.ts
@@ -881,6 +881,7 @@ test.describe('Queue sidebar', () => {
     test.beforeEach(async ({ comfyPage }) => {
       await comfyPage
         .setupHistory()
+        .clearTasks()
         .withTask([secondImage])
         .withTask([firstImage])
         .setupRoutes()
@@ -902,8 +903,10 @@ test.describe('Queue sidebar', () => {
       const newImage = 'image64x64.webp'
       comfyPage.setupHistory().withTask([newImage])
       await comfyPage.menu.queueTab.triggerTasksUpdate()
+      await comfyPage.page.waitForTimeout(256)
       const newTask = comfyPage.menu.queueTab.tasks.getByAltText(newImage)
       await newTask.waitFor({ state: 'visible' })
+      await comfyPage.nextFrame()
 
       // The active gallery item should still be the initial image
       expect(comfyPage.menu.queueTab.getGalleryImage(firstImage)).toBeVisible()
@@ -925,8 +928,9 @@ test.describe('Queue sidebar', () => {
         test(`can navigate gallery ${description}`, async ({ comfyPage }) => {
           for (const direction of path)
             await comfyPage.page.keyboard.press(`Arrow${direction}`, {
-              delay: 64
+              delay: 256
             })
+          await comfyPage.nextFrame()
           expect(comfyPage.menu.queueTab.getGalleryImage(end)).toBeVisible()
         })
       })