Live terminal output #1347
Merged
Live terminal output #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
huchenlei
requested changes
Oct 28, 2024
huchenlei
requested changes
Oct 29, 2024
huchenlei
reviewed
Oct 29, 2024
huchenlei
approved these changes
Oct 30, 2024
|
Looks good! Going to merge this after comfyanonymous/ComfyUI#5396 lands in the backend. |
This was referenced Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for streaming logs via websockets.
Uses xterm.js (same terminal as vscode) for rendering.
A client subscribes to the logs when the terminal is open, and unsubs when it is closed to reduce traffic.
Requires backend PR comfyanonymous/ComfyUI#5396