feat: Add download progress to sidebar #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
requested changes
Nov 10, 2024
There was a problem hiding this comment.
Sorry we probably didn't communicate this clear enough. The fault is probably on me and Robin. I think the requirement is simpler than the current impl. We think moving the list of download items (Progress bar + Action buttons) before the models tree should be good enough, i.e. we don't need to mess with the tree impl.
huchenlei
reviewed
Nov 10, 2024
|
For cancelled / errored out items, can we add an option to remove the item from the list? Can add that in next PR. |
huchenlei
requested changes
Nov 12, 2024
huchenlei
approved these changes
Nov 12, 2024
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Requires Comfy-Org/desktop#214 to work properly
Screen.Recording.2024-11-11.082237.mp4