Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lobe-i18n setup and translation scripts and update translation files for consistency #1751

Merged
merged 5 commits into from
Dec 2, 2024

Conversation

shinshin86
Copy link
Collaborator

Hello!

I recall hearing about a plan to use LLM-based tools for translations in this project, so I created this PR to introduce lobe-i18n to ComfyUI.

You can refer to the README for detailed usage instructions, but this tool allows you to generate translations in bulk using the OpenAI API.

This is purely a suggestion, so if it does not align with ComfyUI's direction or policies, feel free to close the PR without any concerns.

That said, I want to inform you about two potential challenges related to this PR:

OpenAI API Key is Required for Translations

An OpenAI API key is necessary to execute the translation process.
However, for an open-source project like ComfyUI, I am uncertain about the best way to manage this.
I would appreciate any input or guidance on this matter.

Manual Adjustments May Be Needed

As this uses an LLM-based translation tool, there might occasionally be translations that feel slightly off in certain languages. For example, I made the following manual adjustments:
Example adjustments go here

Once these adjustments are made manually, they will be skipped in subsequent translation runs, so it might not be a significant issue.

That's all for the PR!
Please feel free to comment if you have any questions or suggestions for changes.

Copy link

socket-security bot commented Nov 30, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@lobehub/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +97 76.9 MB canisminor1990

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@shinshin86
Copy link
Collaborator Author

I previously changed the file names to the format en_US. However, I later realized that this format was not necessary. Therefore, I have reverted to the original naming convention.
445482c

@huchenlei
Copy link
Member

Thanks for everything you did! This is very helpful to the project. I have invited you as collaborator of this repo. Please make sure you received the invite. Thanks again!

@huchenlei huchenlei merged commit 9ef4018 into Comfy-Org:main Dec 2, 2024
9 checks passed
@shinshin86
Copy link
Collaborator Author

Thank you for reviewing!
And thank you for inviting me as a collaborator. I’ve confirmed the invitation.
I look forward to continuing our collaboration.

@shinshin86 shinshin86 deleted the add-lobehub-i18n-cli branch December 2, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants