Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Style] Set topbar height to 2.5rem (40px) #2224

Merged
merged 1 commit into from
Jan 11, 2025
Merged

[Style] Set topbar height to 2.5rem (40px) #2224

merged 1 commit into from
Jan 11, 2025

Conversation

huchenlei
Copy link
Member

@huchenlei huchenlei commented Jan 10, 2025

Ref: #2209 (comment)

Previous height was calculated from the content, which resulted in a 38.5px fractional number.

┆Issue is synchronized with this Notion page by Unito

@huchenlei huchenlei requested a review from a team as a code owner January 10, 2025 22:53
@huchenlei huchenlei added the New Browser Test Expectations New browser test screenshot should be set by github action label Jan 10, 2025
@huchenlei huchenlei merged commit 0c4fd4a into main Jan 11, 2025
10 of 11 checks passed
@huchenlei huchenlei deleted the topbar_height branch January 11, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Browser Test Expectations New browser test screenshot should be set by github action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant