Add forms plugin to issue report component #2302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove and inline CheckboxGroup component - add PrimeVue forms integration
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
huchenlei
reviewed
Jan 20, 2025
src/types/primevue.d.ts
Outdated
| @@ -0,0 +1,10 @@ | |||
| declare module '@primevue/forms/resolvers/zod' { | |||
There was a problem hiding this comment.
Can you link the issue primefaces/primevue#6722 here to explain why this file need to be added?
There was a problem hiding this comment.
The issue is also resolved by updating primevue from v4.0.5 to match the version of primevue/forms which starts at v4.2.0
christian-byrne
requested review from
Yorha4D,
KarryCharon,
DorotaLuna,
shinshin86 and
a team
as code owners
huchenlei
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the primevue-forms plugin and integrates it with the ReportIssuePanel component, adding validation against a form schema and providing responsive messages for validation failures according to the given errored field.
forms-ux.mp4
┆Issue is synchronized with this Notion page by Unito