Skip to content

Commit

Permalink
Add note about rebuild
Browse files Browse the repository at this point in the history
  • Loading branch information
pythongosssss committed Nov 13, 2024
1 parent a2202a9 commit c4dd6ab
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 3 deletions.
18 changes: 18 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,24 @@ You can also build the package and/or distributables using the `make` command:
yarn make
```

If you get an error similar to:
```
The module '/electron/node_modules/node-pty/build/Release/pty.node' was compiled against a different Node.js version using NODE_MODULE_VERSION 115. This version of Node.js requires NODE_MODULE_VERSION 125. Please try re-compiling or re-installing the module (for instance, using `npm rebuild` or `npm install`).
```
You will need to rebuild the node-pty using [electron-rebuild](https://www.electronjs.org/docs/latest/tutorial/using-native-node-modules), for example:
```
npx electron-rebuild
```
or if that fails
```
yarn install -D electron-rebuild
rm -rf node_modules
rm yarn.lock
yarn install
electron-rebuild
```


# Release

We use Todesktop to build and codesign our releases. To make a new release:
Expand Down
6 changes: 3 additions & 3 deletions src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ if (!gotTheLock) {
}

function loadComfyIntoMainWindow() {
appWindow.loadURL(`http://${host}:${port}`);
appWindow.loadURL(`http://localhost:${5174}`);
}
function restartApp({ customMessage, delay }: { customMessage?: string; delay?: number } = {}): void {
function relaunchApplication(delay?: number) {
Expand Down Expand Up @@ -365,8 +365,8 @@ const launchPythonServer = async (
'--output-directory',
outputDirectoryPath,
...(process.env.COMFYUI_CPU_ONLY === 'true' ? ['--cpu'] : []),
'--front-end-root',
path.join(appResourcesPath, 'ComfyUI', 'web_custom_versions', 'desktop_app'),
// '--front-end-root',
// path.join(appResourcesPath, 'ComfyUI', 'web_custom_versions', 'desktop_app'),
'--extra-model-paths-config',
modelConfigPath,
'--port',
Expand Down

0 comments on commit c4dd6ab

Please sign in to comment.