Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add electron adapter frontend extension #127

Merged
merged 7 commits into from
Oct 28, 2024
Merged

Add electron adapter frontend extension #127

merged 7 commits into from
Oct 28, 2024

Conversation

huchenlei
Copy link
Member

@huchenlei huchenlei commented Oct 25, 2024 •
edited
Loading

image

electron_open_logs.mp4

@robinjhuang I will leave it to you on porting other settings / menu actions.

I think the electronAPI object need major revamp as it currently is used serve 2 purposes:

  • Renderer send IPC to browser
  • Renderer to receive IPC from browser

@huchenlei huchenlei marked this pull request as ready for review October 28, 2024 16:54
@huchenlei huchenlei requested a review from robinjhuang October 28, 2024 16:58
@robinjhuang
Copy link
Member

@huchenlei maybe we call it the section ComfyUI Desktop instead of "Comfy Electron"?

@huchenlei
Copy link
Member Author

@huchenlei maybe we call it the section ComfyUI Desktop instead of "Comfy Electron"?

Done.

@huchenlei huchenlei merged commit 3c009be into main Oct 28, 2024
6 checks passed
@huchenlei huchenlei deleted the frontend_extension branch October 28, 2024 17:05
This was referenced Oct 28, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinjhuang robinjhuang Awaiting requested review from robinjhuang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huchenlei @robinjhuang