Yarn Dev/Make Fixes, Local ComfyCLI Fix, Todesktop security adjustments #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the issue Cleaned up and added Documentation Format Fix Bumped up Icon size
robinjhuang
reviewed
Oct 31, 2024
index.html
Outdated
| @@ -2,6 +2,7 @@ | |||
| <html> | |||
| <head> | |||
| <meta charset="UTF-8" /> | |||
| <meta http-equiv="Content-Security-Policy" content="script-src 'self'" /> | |||
There was a problem hiding this comment.
src/main.ts
Outdated
| process.env.PUBLISH == true && | ||
| todesktop.init({ | ||
| customLogger: log, | ||
| updateReadyAction: { showInstallAndRestartPrompt: 'always', showNotification: 'always' }, |
There was a problem hiding this comment.
autoUpdater was removed from the previous diff.
There was a problem hiding this comment.
It needs to inherit from comfySettings.autoUpdate
There was a problem hiding this comment.
OK I see, fyi if your on Mac if your not code signed it won't auto-update, this is at least on the default app not sure if Mac for Todesktop uses a diff process
https://www.electron.build/auto-update.html
src/main.ts
Outdated
| log.info('Opened Vite Dev Server'); | ||
| mainWindow.webContents.openDevTools(); | ||
| } else { | ||
| mainWindow.loadFile(path.join(__dirname, `../renderer/index.html`)); | ||
| } | ||
|
|
||
| session.defaultSession.setPermissionRequestHandler((webContents, permission, callback) => { |
There was a problem hiding this comment.
src/main.ts
Outdated
Comment on lines
392
to
395
| mainWindow.webContents.on('will-navigate', (event, newURL) => { | ||
| const approvedHosts: Array<string> = [ | ||
| `http://${host}:${port}`, | ||
| process.env.VITE_DEV_SERVER_URL as string, |
There was a problem hiding this comment.
robinjhuang
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.