Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Icons / System Tray #14

Merged
merged 14 commits into from
Sep 8, 2024
Merged

App Icons / System Tray #14

merged 14 commits into from
Sep 8, 2024

Conversation

KenCorma
Copy link
Collaborator

@KenCorma KenCorma commented Sep 8, 2024

Set Comfy icons for app and system tray.

Developed System Tray Behavior. App no longer quits if window is closed as the python server will continue to run in the background. Clicking the system tray you can bring comfy back up, quit or hide.

@KenCorma
Copy link
Collaborator Author

KenCorma commented Sep 8, 2024

@telamonian So I had to change the extraResource property back to a list. Electron-forge will copy in place the assets folder so the output looks like this resources/assets/comfyUI . Now I think your right that all these things should be in a folder, makes it cleaner when looking at the build resources folder what is electron (lang files/ app.asar) and comfy. So I am going to make another Branch/PR that we can use to clean up this pathing and make sure all the code is consistent .

@KenCorma KenCorma merged commit 7446c7d into main Sep 8, 2024
4 checks passed
@KenCorma KenCorma deleted the dev-kendal-systemtray branch September 8, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants