Add electron API to open external URLs. #153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
reviewed
Oct 31, 2024
There was a problem hiding this comment.
Is there a solution without modification on the frontend side? Some extensions might have links that out of our control.
Claude gives following solution:
const { app, BrowserWindow, shell } = require('electron')
function createWindow() {
const win = new BrowserWindow({
width: 800,
height: 600,
webPreferences: {
webviewTag: true,
nodeIntegration: true,
contextIsolation: false
}
})
// Load your HTML file containing the webview
win.loadFile('index.html')
}
app.whenReady().then(createWindow)
// In your renderer process (index.html)
<html>
<body>
<webview id="myWebview" src="https://example.com"></webview>
<script>
const webview = document.getElementById('myWebview')
webview.addEventListener('new-window', (event) => {
event.preventDefault()
shell.openExternal(event.url)
})
webview.addEventListener('will-navigate', (event) => {
// Optional: intercept navigation events as well
event.preventDefault()
shell.openExternal(event.url)
})
</script>
</body>
</html>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #138
ComfyUI_frontendneeds to add something like :