Draft: Refactor installation state. #216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
reviewed
Nov 10, 2024
| import { AppWindow } from '../main-process/appWindow'; | ||
| import { ComfyConfigManager } from '../config/comfyConfigManager'; | ||
|
|
||
| type InstallationState = |
There was a problem hiding this comment.
Let's just keep this a simple enum matching ProgressStatus, and get the validation and location stuff in separate API.
robinjhuang
force-pushed
the
rh-install
branch
from
98029c2 to
44cef85
Compare
|
See also: #228 |
huchenlei
force-pushed
the
rh-install
branch
from
44cef85 to
ce150c6
Compare
|
Installation state will be stored in the frontend, and finally when everything are validated, the frontend will send all relevant info to the electron backend to initiate the download. There will be no need to track the state in the electron side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the main process will send events and state to the renderer for the initial onboarding installation.
This is brittle because the renderer state can become out of sync if it misses messages.
This refactor stores the current state of the installation, and registers an IPC event so the renderer can always request the up to date state.