Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ComfyUI-Manager to manager-core. #227

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Rename ComfyUI-Manager to manager-core. #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1451636
Rename ComfyUI-Manager to manager-core.
robinjhuang Nov 12, 2024
4d5113f
Checkout specific manager core commit.
robinjhuang Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
"packageManager": "[email protected]",
"config": {
"frontendVersion": "1.3.33",
"comfyVersion": "0.2.7"
"comfyVersion": "0.2.7",
"managerCommit": "cfdb687db3a7d2554f4f0e1f982ad9fffb3c4f2e"
},
"scripts": {
"clean": "rimraf .vite dist out",
Expand Down
16 changes: 12 additions & 4 deletions scripts/makeComfy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
const { execSync } = require('child_process');
const pkg = require('../package.json');
const fs = require('fs');

function makeAssets(gpuFlag) {
const baseCommand = [
Expand All @@ -8,18 +9,25 @@ function makeAssets(gpuFlag) {
`comfy-cli --skip-prompt --here install --version ${pkg.config.comfyVersion} --fast-deps`,
gpuFlag,
'--manager-url https://github.com/Comfy-Org/manager-core',
'--manager-commit',
pkg.config.managerCommit,
'&&',
'comfy-cli --here standalone',
'&&',
'yarn run make:frontend'
].join(' ');

// Special case for macOS which needs additional checks
if (gpuFlag === '--m-series') {
return execSync(`${baseCommand} && ../scripts/checkAssetsMacos.sh python`, { stdio: 'inherit' });
execSync(`${baseCommand} && ../scripts/checkAssetsMacos.sh python`, { stdio: 'inherit' });
} else {
execSync(baseCommand, { stdio: 'inherit' });
}

execSync(baseCommand, { stdio: 'inherit' });

// Rename custom_nodes/ComfyUI-Manager to manager-core
if (!fs.existsSync('assets/ComfyUI/custom_nodes/ComfyUI-Manager')) {
throw new Error('ComfyUI-Manager not found');
}
fs.renameSync('./assets/ComfyUI/custom_nodes/ComfyUI-Manager', './assets/ComfyUI/custom_nodes/manager-core');
}

// Get GPU flag from command line argument
Expand Down
Loading