Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update debugger endsPattern #266

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Update debugger endsPattern #266

merged 2 commits into from
Nov 16, 2024

Conversation

robinjhuang
Copy link
Member

@robinjhuang robinjhuang commented Nov 15, 2024

On my mac, the debugger attaches but does not with the previous endsPattern. It might be because it attaches after 'App ready' and then doesn't have time to register breakpoints before the code is executed?

Debugger does not break on "log.info("Checking if first time...)". Previous logs:

Debugger listening on ws://127.0.0.1:9223/e05a13aa-1fe3-4339-9359-13de0dace872
For help, see: https://nodejs.org/en/docs/inspector
14:46:20.607 › @todesktop/runtime: AutoUpdater: electron will-finish-launching event emitted { appVersion: '0.3.0', runtimeVersion: '1.6.4' }
@todesktop/runtime: skipping autoUpdater initialization because application is not packaged.
14:46:20.611 › @todesktop/runtime: AutoUpdater: @todesktop/runtime: skipping autoUpdater initialization because application is not packaged.
14:46:20.634 › App ready
Debugger attached.
14:46:20.767 › Checking if first time setup is complete. Extra models config path: /Users/junhanhuang/Library/Application Support/ComfyUI/extra_models_config.yaml

With this update, the debugger attaches earlier:

Debugger listening on ws://127.0.0.1:9223/5e8315b4-321d-4feb-a196-c567deea5404
For help, see: https://nodejs.org/en/docs/inspector
Debugger attached.
14:49:52.523 › @todesktop/runtime: AutoUpdater: electron will-finish-launching event emitted { appVersion: '0.3.0', runtimeVersion: '1.6.4' }

Update README as well.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 60.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@huchenlei huchenlei merged commit 17f4f84 into main Nov 16, 2024
7 checks passed
@huchenlei huchenlei deleted the rh-debug2 branch November 16, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants