Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom wait logic with wait-on package #278

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Conversation

huchenlei
Copy link
Member

@huchenlei huchenlei commented Nov 17, 2024

This PR replaces custom waiting logic for ComfyUI server with wait-on package. This greatly simplifes the code.

Ref: wait-on package: https://github.com/jeffbski/wait-on#readme

Copy link

codecov bot commented Nov 17, 2024

The author of this PR, huchenlei, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at [email protected] with any questions.

@huchenlei huchenlei merged commit 7cd4756 into main Nov 17, 2024
7 checks passed
@huchenlei huchenlei deleted the wait_ready branch November 17, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant