Launch comfy server with extra args specified in setting json #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So we just need v1.4.8 for this feature to work? |
huchenlei
force-pushed
the
launch_args
branch
from
5d0121f to
f829819
Compare
Yes. The only thing left is a message to prompt user restart the app. I will add that in the next frontend release. 1.4.9 is usable, just some frictions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #274
Context: Comfy-Org/ComfyUI_frontend#1644
This PR makes electron side read
Comfy.Server.LaunchArgsfrom settings json and merge them with core server args.