Settings store #362
Merged
Settings store #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
webfiltered
force-pushed
the
settings-store
branch
3 times, most recently
from
e1a0eaa to
a5469b8
Compare
If present, the config must be valid to proceed with app startup.
Provides the user with some information about what went wrong and why - and where they can look to fix it. Needs help / support button added.
webfiltered
force-pushed
the
settings-store
branch
from
a5469b8 to
64fab8d
Compare
huchenlei
requested changes
Dec 3, 2024
|
|
||
| export type DesktopSettings = { | ||
| basePath?: string; | ||
| installState?: 'started' | 'installed' | 'upgraded'; |
There was a problem hiding this comment.
Can you add some documentation explaining what each state represents? Do we have a plan to expand this install state to track more stages during installation so that we can resume at certain state on install retry?
huchenlei
approved these changes
Dec 3, 2024
robinjhuang
added a commit
that referenced
this pull request
Dec 5, 2024
This reverts commit 54f1a96.
Merged
robinjhuang
added a commit
that referenced
this pull request
Dec 5, 2024
webfiltered
added a commit
that referenced
this pull request
Dec 6, 2024
huchenlei
pushed a commit
that referenced
this pull request
Dec 6, 2024
* Reapply "Settings store (#362)" (#440) This reverts commit 81320e2. * Allow user to see result of YAML config read - Nature of the failure is returned - Invalid values read are included if available - Retains inferred types * Fix cannot start app if invalid install state Current requirement is that a missing YAML file triggers the install screen. * Detect YAML parse exceptions * Update test expectations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an electron-store config store to house desktop-specific installation state / config. Includes fairly(?) complete error handling and pre-window interaction.
config.json{ "basePath": "C:\\Users\\User\\Documents\\ComfyUI", "installState": "installed" }undefineduntil an install has started,'started', or'installed'.'upgraded'status is temporarily used when upgrading from a version prior to this PR, and changed to'installed'when successfulbase_pathinextra_models_config.yamlis still the source of truthbasePathin config.json is used as a fallback onlyFailures
If the settings store is invalid (file is present, but can't be parsed as json), the user is prompted to resolve the issue:
Confirmation if they choose to reset:
Resolves #360