Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure NVIDIA users without wmic can install #382

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Ensure NVIDIA users without wmic can install #382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,22 @@ export async function validateHardware(): Promise<HardwareValidation> {

if (!hasNvidia) {
try {
await execAsync('nvidia-smi');
// wmic is unreliable. Check in PS.
const res = await execAsync(
'powershell.exe -c "$n = \'*NVIDIA*\'; Get-CimInstance win32_videocontroller | ? { $_.Name -like $n -or $_.VideoProcessor -like $n -or $_.AdapterCompatibility -like $n }"'
);
if (!res) throw new Error('No video card');
return { isValid: true };
} catch {
return {
isValid: false,
error: 'ComfyUI requires an NVIDIA GPU on Windows. No NVIDIA GPU was detected.',
};
try {
await execAsync('nvidia-smi');
return { isValid: true };
} catch {
return {
isValid: false,
error: 'ComfyUI requires an NVIDIA GPU on Windows. No NVIDIA GPU was detected.',
};
}
}
}

Expand Down
Loading