enh: Add Check For Updates button #466
Open
+56
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
requested changes
Dec 12, 2024
| try { | ||
| const result = await todesktop.autoUpdater?.checkForUpdates(); | ||
| if (result?.updateInfo) { | ||
| log.info('Update found:', result.updateInfo.version); |
There was a problem hiding this comment.
Let's split this function into following 2 functions:
checkForUpdates: Check for update and returns the update infoupdateToLatest: Actually restart and do the update
| @@ -31,6 +32,7 @@ export const IPC_CHANNELS = { | |||
| SHOW_DIRECTORY_PICKER: 'show-directory-picker', | |||
| INSTALL_COMFYUI: 'install-comfyui', | |||
| SHOW_CONTEXT_MENU: 'show-context-menu', | |||
| GET_OS_PLATFORM: 'get-os-platform', | |||
There was a problem hiding this comment.
Why do we need the OS_PLATFORM in electron API?
There was a problem hiding this comment.
Per specification the menu item should show only if the application is ran on Win32 platform so I need to way to determine that in frontend.
There was a problem hiding this comment.
We have a duplicate here - one sec.
Edit: See commit here - you can just call process.platform. No need for IPC, it just needs to be node.js not web app.
@huchenlei My req. was hiding e.g. Apple MPS as an option on Windows.
There was a problem hiding this comment.
Can we have the getOS API added in a separate PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Electron portion of #447
┆Issue is synchronized with this Notion page by Unito