Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GPU selection to installer #468

Merged
merged 18 commits into from
Dec 14, 2024
Merged

Add GPU selection to installer #468

merged 18 commits into from
Dec 14, 2024

Conversation

webfiltered
Copy link
Contributor

GPU installation options

  • Adds GPU selection screen
  • If a supported GPU is detected, it is pre-selected
  • Allows user to pick whatever they wish
  • Installs the appropriate pytorch for the selection
  • Includes support for CPU mode
  • Adds flag that auto-starts in CPU mode
  • Stores selected GPU in config.json for future ref / debugging

@webfiltered webfiltered requested review from robinjhuang and huchenlei and removed request for robinjhuang December 12, 2024 15:07
@webfiltered webfiltered mentioned this pull request Dec 12, 2024
Merged
@webfiltered webfiltered marked this pull request as ready for review December 12, 2024 20:26
@webfiltered
Remove circular dependency
3f0b65e 
Allows desktop change to be merged prior to frontend changes for this feature.
huchenlei
huchenlei requested changes Dec 12, 2024
View reviewed changes
src/utils.ts Outdated Show resolved Hide resolved
robinjhuang
robinjhuang approved these changes Dec 13, 2024
View reviewed changes
src/virtualEnvironment.ts Outdated Show resolved Hide resolved
src/store/desktopConfig.ts Outdated Show resolved Hide resolved
huchenlei
huchenlei requested changes Dec 13, 2024
View reviewed changes
src/preload.ts Outdated Show resolved Hide resolved
src/preload.ts Outdated Show resolved Hide resolved
src/store/index.ts Outdated Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
@webfiltered webfiltered requested a review from a team as a code owner December 14, 2024 02:49
@webfiltered
Copy link
Contributor Author

E2E tested by hand with both 1.5.10 frontend, and PR frontend.

@webfiltered webfiltered merged commit e251941 into main Dec 14, 2024
7 checks passed
@webfiltered webfiltered deleted the do-that-gpu-thing branch December 14, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huchenlei huchenlei huchenlei requested changes

@robinjhuang robinjhuang robinjhuang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@webfiltered @robinjhuang @huchenlei