Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert repo from CommonJS to ES Modules #491

Merged
merged 9 commits into from
Dec 16, 2024
Merged

Convert repo from CommonJS to ES Modules #491

merged 9 commits into from
Dec 16, 2024

Conversation

webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Dec 15, 2024 •
edited
Loading

  • Converts most CommonJS code into ES Modules
  • preload.ts now compiles to preload.cjs - this is a one-off special case
    • File is still TypeScript, but its transpile format is unchanged - cjs instead of es
    • Electron supports more features and requires less working around to inject this file as CJS
  • Renamed preMake.cjs, which remains as CommonJS - requirement of build process
  • vite config now has full proper typing
  • ESLint and other tooling can be installed 🎉

@webfiltered webfiltered requested a review from a team as a code owner December 15, 2024 19:52
@huchenlei huchenlei merged commit 524aeeb into main Dec 16, 2024
8 checks passed
@huchenlei huchenlei deleted the esm branch December 16, 2024 18:38
@webfiltered webfiltered mentioned this pull request Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huchenlei huchenlei huchenlei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webfiltered @huchenlei