Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vitest & cross-platform test support #540

Merged
merged 8 commits into from
Dec 23, 2024
Merged

Add vitest & cross-platform test support #540

merged 8 commits into from
Dec 23, 2024

Conversation

webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Dec 19, 2024

  • Requires Lint & refactor codebase #539
  • Makes tests platform-agnostic
  • Replaces jest with vitest
  • Fixes test watch issue - prevents temp files from being created in source directory
  • Minor refactors / linting

┆Issue is synchronized with this Notion page by Unito

@webfiltered webfiltered marked this pull request as ready for review December 19, 2024 03:34
@webfiltered webfiltered requested review from a team as code owners December 19, 2024 03:34
Copy link

socket-security bot commented Dec 19, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] None 0 5.81 kB types
npm/[email protected] unsafe 0 4.51 kB sindresorhus
npm/[email protected] None 0 8.54 kB samverschueren
npm/[email protected] None 0 765 kB zloirock
npm/[email protected] None 0 9.04 kB qix
npm/[email protected] None 0 711 kB sindresorhus
npm/[email protected] None 0 13 kB ljharb
npm/[email protected] None 0 16.7 kB ljharb
npm/[email protected] None 0 12.8 kB ljharb
npm/[email protected] None 0 4.05 kB qix
npm/[email protected] None 0 14.8 kB ljharb
npm/[email protected] None 0 22.1 kB ljharb
npm/[email protected] None 0 3.88 kB sindresorhus
npm/[email protected] None 0 20.8 kB ljharb
npm/[email protected] None 0 22.2 kB ljharb
npm/[email protected] None 0 22 kB ljharb
npm/[email protected] None 0 10.4 kB isaacs
npm/[email protected] None 0 5.39 kB eventualbuddha
npm/[email protected] None 0 2.97 kB thejameskyle
npm/[email protected] None 0 26.6 kB audrey.e
npm/[email protected] None 0 5.41 kB sindresorhus
npm/[email protected] None 0 17.7 kB blakeembrey
npm/[email protected] None 0 10.9 kB ljharb
npm/[email protected] None 0 6.73 kB sindresorhus
npm/[email protected] filesystem 0 6.05 kB sindresorhus
npm/[email protected] None 0 314 kB dmitrysoshnikov
npm/[email protected] None 0 66 kB jviereck
npm/[email protected] None 0 16.7 kB ljharb
npm/[email protected] None 0 23.4 kB kemitchell
npm/[email protected] None 0 11.8 kB kemitchell
npm/[email protected] None 0 3.31 kB sindresorhus
npm/[email protected] None 0 16.6 kB kemitchell
npm/[email protected] None 0 15 kB ljharb

🚮 Removed packages: npm/@jest/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@sinclair/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@webfiltered webfiltered marked this pull request as draft December 19, 2024 17:04
@huchenlei
Copy link
Member

Will review after rebase.

Copy link
Member

@robinjhuang robinjhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vite.preload.config.ts Show resolved Hide resolved
@webfiltered
Copy link
Contributor Author

webfiltered commented Dec 21, 2024

This PR introduces a dev-only, but mildly annoying regression - vite v6 upgrade breaks 'watch' mode.

Resolved in #544. No impact to prod.

(Edit: Added this comment just for history / ease of any future review. With the scope so small, I don't believe it is worth the effort to re-rebase the PRs, or overcomplicate this one.)

@huchenlei huchenlei merged commit bb82891 into main Dec 23, 2024
7 checks passed
@huchenlei huchenlei deleted the vitest branch December 23, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants