Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Add e2e test on beforeunload bug #721

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Jan 24, 2025

This PR adds a test on the issue fixed in Comfy-Org/ComfyUI_frontend#2318 by creating an unsaved workflow and then closing the page with runBeforeUnload option enabled.

Additional Changes:

  • Switch to using Playwright Electron
  • Before each test, delete existing config file in order to simulate new user
  • After each test, teardown electron process and browser
  • Add fixtures

Running with npx playwright test --ui:

electron-playwright.mp4

┆Issue is synchronized with this Notion page by Unito

@christian-byrne christian-byrne changed the title Add e2e test on beforeunload bug [Test] Add e2e test on beforeunload bug Jan 24, 2025
@christian-byrne christian-byrne marked this pull request as ready for review January 26, 2025 12:21
@christian-byrne christian-byrne requested review from a team as code owners January 26, 2025 12:21
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Jan 26, 2025
@christian-byrne christian-byrne removed the bug Something isn't working label Jan 26, 2025
@christian-byrne christian-byrne marked this pull request as draft January 26, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant