Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Fix path-reliant tests on Windows #723

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Jan 24, 2025

┆Issue is synchronized with this Notion page by Unito

@webfiltered webfiltered requested a review from a team as a code owner January 24, 2025 11:14
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Jan 24, 2025
@webfiltered
Copy link
Contributor Author

@christian-byrne Can you PTAL? The updated tests should work exactly as before, but on all platforms.

Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 24, 2025
@webfiltered
Copy link
Contributor Author

😆 I spend ten minutes on tests and you thank me... thank you!

@webfiltered webfiltered merged commit 95b5c2d into main Jan 24, 2025
6 checks passed
@webfiltered webfiltered deleted the tests-cross-platform branch January 24, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DevTask] Path-related tests fail on Windows
2 participants