Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TS types - Widgets #428

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Fix TS types - Widgets #428

merged 3 commits into from
Jan 20, 2025

Conversation

webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Jan 20, 2025 •
edited
Loading

@webfiltered
Remove downstream types
4bfb4f2 
These optional type definitions were test code and should not have been upstreamed.
@webfiltered
Remove unnecessary workaround
750f56f 
Build workaround TS conversion; no longer relevant.
@webfiltered
Fix TS type - widget size callback
1dbd293
@webfiltered webfiltered mentioned this pull request Jan 20, 2025
Merged
@huchenlei huchenlei merged commit 604a3e6 into master Jan 20, 2025
3 of 4 checks passed
@huchenlei huchenlei deleted the widget-ts-types branch January 20, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huchenlei huchenlei huchenlei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webfiltered @huchenlei