Skip to content

Commit

Permalink
[terraform] Use JSON logs in Blob Cleanup task
Browse files Browse the repository at this point in the history
Summary: We have separate task definition for blob cleanup. Now, when Blob Service supports JSON logs, we can enable them for this task too

Test Plan: terraform plan. I'll check logs format after this is landed by browsing [[ https://us-east-2.console.aws.amazon.com/cloudwatch/home?region=us-east-2#logsV2:log-groups/log-group/$252Fecs$252Fblob-cleanup | the /ecs/blob-cleanup ]] log group.

Reviewers: will

Reviewed By: will

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D13444
  • Loading branch information
barthap committed Sep 25, 2024
1 parent 16b1b1e commit 07fa6f5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 0 additions & 1 deletion services/terraform/remote/aws_cloudwatch_alarms.tf
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ resource "aws_cloudwatch_log_group" "ecs_task_stop" {
}

resource "aws_cloudwatch_event_target" "ecs_task_stop" {

rule = aws_cloudwatch_event_rule.ecs_task_stop.name
arn = aws_cloudwatch_log_group.ecs_task_stop.arn
}
Expand Down
4 changes: 4 additions & 0 deletions services/terraform/remote/task_blob_cleanup.tf
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ resource "aws_ecs_task_definition" "blob_cleanup" {
{
name = "BLOB_S3_BUCKET_NAME",
value = local.blob_service_s3_bucket
},
{
name = "COMM_SERVICES_USE_JSON_LOGS",
value = local.comm_services_use_json_logs
}
]
logConfiguration = {
Expand Down

0 comments on commit 07fa6f5

Please sign in to comment.