Skip to content

Commit

Permalink
[landing] Reset messageSentRef.current on error
Browse files Browse the repository at this point in the history
Summary:
Some folks reported issues with this flow earlier today. The reports came in within a single hour period, so I suspect transient network issues.

I spent some time looking at the code here that handles talking to the relay server, and one potential risk here is that if there's an error after the URL redirect occurs, we'll never retry that step. Probably a good idea to reset this, so that if a retry is necessitated after a URL redirect, we can retry the process from the start (including redoing the URL redirect).

Depends on D13580

Test Plan:
I tested this one the same as the previous two, which is to say I followed [this doc on Notion](https://www.notion.so/commapp/How-to-test-Farcaster-connect-screen-114d823c518b80cf9b10da4d961bc807) for both physical iOS and Android devices

Ideally I'd test the `isError` state here, but it would be really expensive since I'd need to patch `@farcaster/auth-kit` to force `isError`, but that package distributes transpiled source

Reviewers: varun, will

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D13581
  • Loading branch information
Ashoat committed Oct 3, 2024
1 parent 48a911c commit 4ea4695
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions landing/connect-farcaster.react.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ function ConnectFarcaster(): React.Node {
return;
}
if (isError) {
messageSentRef.current = false;
reconnect();
}

Expand Down

0 comments on commit 4ea4695

Please sign in to comment.