Skip to content

Commit

Permalink
[lib][native] fix farcaster outline icon and update CommIcons.ttf
Browse files Browse the repository at this point in the history
Summary:
icon was off center and as a result looked a little strange on web. it also wasn't an outline like the other icons in the list. lastly, i forgot to include the updated CommIcons.ttf file, which we need to make the icon available on native

this diff re-centers the icon, makes it an outline, and updates CommIcons.ttf

Test Plan:
icon looks correct now. CommIcons.ttf update is tested in next diff which actually uses it to display farcaster icon on native (android)

also tested that some of the existing CommIcon icons (e.g. "cloud-filled") still look right on native

{F2810494}

Reviewers: will

Reviewed By: will

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D13475
  • Loading branch information
vdhanan committed Sep 26, 2024
1 parent cdf60ff commit b7a9f62
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions lib/shared/comm-icon-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@
{
"icon": {
"paths": [
"M257.778 155.556H742.222V844.445H671.111V528.889H670.414C662.554 441.677 589.258 373.333 500 373.333C410.742 373.333 337.446 441.677 329.586 528.889H328.889V844.445H257.778V155.556Z",
"M128.889 253.333L157.778 351.111H182.222V746.667C169.949 746.667 160 756.616 160 768.889V795.556H155.556C143.283 795.556 133.333 805.505 133.333 817.778V844.445H382.222V817.778C382.222 805.505 372.273 795.556 360 795.556H355.556V768.889C355.556 756.616 345.606 746.667 333.333 746.667H306.667V253.333H128.889Z",
"M675.556 746.667C663.282 746.667 653.333 756.616 653.333 768.889V795.556H648.889C636.616 795.556 626.667 805.505 626.667 817.778V844.445H875.556V817.778C875.556 805.505 865.606 795.556 853.333 795.556H848.889V768.889C848.889 756.616 838.94 746.667 826.667 746.667V351.111H851.111L880 253.333H702.222V746.667H675.556Z"
"M245.503 149.022h525.136v87.755h137.305l-55.902 195.431h-8.032v270.662c9.619 10.573 16.244 24.139 18.468 39.159 14.702 13.522 24.003 33.215 24.003 55.176v77.773h-320.439v-77.773c0-21.961 9.257-41.654 24.003-55.176 1.906-12.932 7.079-24.73 14.611-34.531v-160.219l-0.408-4.537c-4.402-50.775-45.784-90.569-96.105-90.569s-91.703 39.839-96.105 90.569l-0.408 4.537v151.643c11.662 11.072 19.784 26.136 22.325 43.106 14.702 13.522 24.003 33.215 24.003 55.176v77.773h-320.439v-77.773c0-21.961 9.257-41.654 24.003-55.176 2.224-15.019 8.848-28.541 18.468-39.159v-270.662h-8.032l-55.902-195.431h129.591v-87.755zM297.639 290.636h-111.985l25.092 87.755h21.235v355.014c-10.663 0-19.285 8.939-19.285 19.92v23.913h-3.857c-10.663 0-19.285 8.894-19.285 19.92v23.913h216.212v-23.913c0-11.026-8.666-19.92-19.285-19.92h-3.857v-23.913c0-11.026-8.666-19.92-19.285-19.92h-3.857v-195.431h0.59c2.722-31.036 14.338-59.351 32.216-82.31 27.27-34.939 69.015-57.309 115.842-57.309 51.456 0 96.876 27.044 123.556 68.153 13.477 20.782 22.189 45.193 24.502 71.421h0.59v195.839c-8.803 1.86-15.428 9.892-15.428 19.556v23.913h-3.857c-10.663 0-19.285 8.894-19.285 19.92v23.913h216.212v-23.913c0-11.026-8.666-19.92-19.285-19.92h-3.857v-23.913c0-11.026-8.666-19.92-19.285-19.92v-355.014h21.236l25.092-87.755h-119.699v-87.755h-420.879v87.755z"
],
"attrs": [{}],
"isMulticolor": false,
Expand Down
Binary file modified native/fonts/CommIcons.ttf
Binary file not shown.

0 comments on commit b7a9f62

Please sign in to comment.