-
Notifications
You must be signed in to change notification settings - Fork 30
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[lib] fix
PushHandler
to support DMs
Summary: Solution described in [ENG-9465](https://linear.app/comm/issue/ENG-9465/messages-from-thick-thread-notifs-dont-seem-to-be-integrated-into#comment-685bf427). Test Plan: Apply this diff: 1. Comment [this](https://github.com/CommE2E/comm/blob/cfc5daf4fbc477221cbd541241e6d9a6fc0774ca/lib/tunnelbroker/peer-to-peer-message-handler.js#L142) line to make sure we're testing actual notifs code & add some logs to make sure code in reducer was executed. 2. Open physical device 3. In DM thread send a test message 4. Notif delivered 5. Message immediately visible in UI 6. Thread marked as unread 5. Logs from reducer are there Reviewers: ashoat, kamil Reviewed By: ashoat Differential Revision: https://phab.comm.dev/D13576
- Loading branch information
Showing
3 changed files
with
32 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters