Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styled current day for easier recognition. #1

Merged
merged 1 commit into from
Dec 22, 2015
Merged

Styled current day for easier recognition. #1

merged 1 commit into from
Dec 22, 2015

Conversation

larryfenn
Copy link
Contributor

ayyyyyyyyy

@Ashoat
Copy link
Contributor

Ashoat commented Dec 22, 2015

lmao

Ashoat added a commit that referenced this pull request Dec 22, 2015
@Ashoat
Merge pull request #1 from larryfenn/master
307559f 
Styled current day for easier recognition.
@Ashoat Ashoat merged commit 307559f into CommE2E:master Dec 22, 2015
Ashoat added a commit that referenced this pull request Aug 26, 2020
@Ashoat
[native] Stop using LayoutAnimation in ChatList
34bc5a4 
Summary:
We want to stop using `LayoutAnimation` because I think it's leading to [weird layout issues on Android](#109).

`LayoutAnimation` does two things for us in `ChatList` right now:
1. Animates the scroll position when new items appear
2. Animates the opacity of new items

This replaces #1 but does not replace #2

Reviewers: zrebcu411, KatPo, palys-swm

Reviewed By: palys-swm

Differential Revision: https://phabricator.ashoat.com/D23
@Ashoat Ashoat mentioned this pull request Oct 26, 2020
Closed
karol-bisztyga pushed a commit that referenced this pull request Aug 10, 2021
[native] Secure store - add ios part
9ef3bd1 
Summary: iOS implementation of `expo-secure-store` for our code

Test Plan:
I used the code below to test these changes:
```
static bool randInit = false;
  {
    if (randInit) {
      Logger::log("here init rand");
      randInit = true;
      srand((unsigned)time(0));
    }
    auto generateRandomString = [](size_t size) {
      std::string str;
      for (size_t i = 0; i < size; ++i) {
        str += 'A' + rand() % 24;
      }
      return str;
    };

    Logger::log("here test secure store #0");
    SecureStore secureStore;
    std::string key = generateRandomString(20);
    Logger::log("here test secure store #1(write): " + key);
    secureStore.set("pickleKey", key);
    std::string result = secureStore.get("pickleKey");
    Logger::log("here test secure store #2 (read): " + result);
  }
```

Reviewers: palys-swm, ashoat

Reviewed By: palys-swm, ashoat

Subscribers: ashoat, palys-swm, Adrian, atul

Differential Revision: https://phabricator.ashoat.com/D1821
karol-bisztyga pushed a commit that referenced this pull request Aug 10, 2021
[native] Secure store - add android part
7e1773a 
Summary: Android implementation for our code of `expo-secure-store`

Test Plan:
I used the code below to test these changes:
```
static bool randInit = false;
  {
    if (randInit) {
      Logger::log("here init rand");
      randInit = true;
      srand((unsigned)time(0));
    }
    auto generateRandomString = [](size_t size) {
      std::string str;
      for (size_t i = 0; i < size; ++i) {
        str += 'A' + rand() % 24;
      }
      return str;
    };

    Logger::log("here test secure store #0");
    SecureStore secureStore;
    std::string key = generateRandomString(20);
    Logger::log("here test secure store #1(write): " + key);
    secureStore.set("pickleKey", key);
    std::string result = secureStore.get("pickleKey");
    Logger::log("here test secure store #2 (read): " + result);
  }
```

Reviewers: palys-swm, ashoat

Reviewed By: palys-swm, ashoat

Subscribers: ashoat, palys-swm, Adrian, atul

Differential Revision: https://phabricator.ashoat.com/D1823
karol-bisztyga pushed a commit that referenced this pull request Aug 12, 2021
[native] Generate Keys - add crypto methods to core module
02cfc76 
Summary:
Adding three methods to the comm core module:
- `initializeCryptoAccount` - I think this should be called right away when the user logs in
  - first, it fetches the account data from SQLite(if there's any)(using a secret key stored in the local store)
  - if there's account data in the local database, it restores the user's state from it
  - if there's no data, it initializes the user and writes their state to the local storage
- `getUserPublicKey` - just returns user's public key
- `getUserOneTimeKeys` - generates a certain amount of user's one-time keys and returns it to the js layer

All those operations are queued on the crypto thread and database thread accordingly.

This revision relies on the following diffs: D1820 D1821 D1823 and it requires them to be landed first.
The original code can be found [here](https://github.com/karol-bisztyga/olm_tests/tree/main/karol_tests)

Test Plan:
Here's a sample code that can be used to test these changes:
```
  (async () => {
    console.log('here just testing js side #0');
    await global.CommCoreModule.initializeCryptoAccount('83810');
    console.log('here just testing js side #1');
    try {
      const idKeys = await global.CommCoreModule.getUserPublicKey('83810');
      console.log('here result on the js side(id keys): ' + idKeys);
      let otKeys = await global.CommCoreModule.getUserOneTimeKeys('83810');
      console.log('here result on the js side(ot keys): ' + otKeys);
      otKeys = await global.CommCoreModule.getUserOneTimeKeys('83810');
      console.log('here result on the js side(ot keys): ' + otKeys);
    } catch (e) {
      console.log('here error on the js side: ');
      console.log(e);
    }
  })();

```

Reviewers: palys-swm, ashoat

Reviewed By: ashoat

Subscribers: ashoat, palys-swm, Adrian, atul

Differential Revision: https://phabricator.ashoat.com/D1846
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larryfenn @Ashoat