Add E2E test

CommerceWeavers · Oct 18, 2024 · 4d37b8d · 4d37b8d
1 parent 5f4e4a5
commit 4d37b8d
Show file tree

Hide file tree

Showing 5 changed files with 40 additions and 8 deletions.
diff --git a/config/config/sylius_fixtures.php b/config/config/sylius_fixtures.php
@@ -137,17 +137,11 @@
                     'enabled' => true,
                 ],
                 'visa_mobile' => [
-                    'code' => 'visa_mobile',
+                    'code' => 'tpay_visa_mobile',
                     'name' => 'Visa mobile (Tpay)',
                     'gatewayFactory' => 'tpay',
                     'gatewayName' => 'tpay',
-                    'gatewayConfig' => [
-                        'client_id' => '%env(string:TPAY_CLIENT_ID)%',
-                        'client_secret' => '%env(string:TPAY_CLIENT_SECRET)%',
-                        'type' => PaymentType::VISA_MOBILE,
-                        'notification_security_code' => '%env(string:TPAY_NOTIFICATION_SECURITY_CODE)%',
-                        'production_mode' => false,
-                    ],
+                    'gatewayConfig' => $tpayConfig + ['type' => PaymentType::VISA_MOBILE],
                     'channels' => [
                         'FASHION_WEB',
                     ],

diff --git a/src/Form/DataTransformer/VisaMobilePhoneDataTransformer.php b/src/Form/DataTransformer/VisaMobilePhoneDataTransformer.php
@@ -5,6 +5,7 @@
 namespace CommerceWeavers\SyliusTpayPlugin\Form\DataTransformer;
 
 use Symfony\Component\Form\DataTransformerInterface;
+use Webmozart\Assert\Assert;
 
 final class VisaMobilePhoneDataTransformer implements DataTransformerInterface
 {
@@ -16,6 +17,8 @@ public function transform($value): ?string
             return '';
         }
 
+        Assert::string($value);
+
         if (strlen($value) > 9 && str_starts_with($value, self::PREFIX)) {
             return substr($value, 2);
         }

diff --git a/tests/E2E/Checkout/TpayPaymentCheckoutTest.php b/tests/E2E/Checkout/TpayPaymentCheckoutTest.php
@@ -56,4 +56,13 @@ public function test_it_completes_the_checkout_using_blik(): void
 
         $this->assertPageTitleContains('Waiting for payment');
     }
+
+    public function test_it_completes_the_checkout_using_visa_mobile(): void
+    {
+        $this->processWithPaymentMethod('tpay_visa_mobile');
+        $this->fillVisaMobile(self::FORM_ID, '123123123');
+        $this->placeOrder();
+
+        $this->assertPageTitleContains('Waiting for payment');
+    }
 }
diff --git a/tests/E2E/Helper/Order/TpayTrait.php b/tests/E2E/Helper/Order/TpayTrait.php
@@ -25,4 +25,9 @@ public function fillBlikToken(string $formId, string $blikToken): void
     {
         $this->client->findElement(WebDriverBy::id(sprintf('%s_tpay_blik_token', $formId)))->sendKeys($blikToken);
     }
+
+    public function fillVisaMobile(string $formId, string $mobilePhone): void
+    {
+        $this->client->findElement(WebDriverBy::id(sprintf('%s_tpay_visa_mobile_phone_number', $formId)))->sendKeys($mobilePhone);
+    }
 }
diff --git a/tests/E2E/Resources/fixtures/common/payment_method.yaml b/tests/E2E/Resources/fixtures/common/payment_method.yaml
@@ -34,6 +34,13 @@ Sylius\Component\Core\Model\PaymentMethod:
         translations:
             - '@tpay_pbl_payment_method_translation'
         channels: [ '@channel_web' ]
+    tpay_visa_mobile:
+        code: 'tpay_visa_mobile'
+        enabled: true
+        gatewayConfig: '@gateway_tpay_visa_mobile'
+        translations:
+            - '@tpay_visa_mobile_payment_method_translation'
+        channels: [ '@channel_web' ]
 
 Sylius\Bundle\PayumBundle\Model\GatewayConfig:
     gateway_tpay:
@@ -81,6 +88,15 @@ Sylius\Bundle\PayumBundle\Model\GatewayConfig:
             type: 'pay_by_link'
             production_mode: false
             encrypted: true
+    gateway_tpay_visa_mobile:
+        gatewayName: 'tpay'
+        factoryName: 'tpay'
+        config:
+            client_id: 'encrypted_<getenv("TPAY_CLIENT_ID")>'
+            client_secret: 'encrypted_<getenv("TPAY_CLIENT_SECRET")>'
+            type: 'visa_mobile'
+            production_mode: false
+            encrypted: true
 
 Sylius\Component\Payment\Model\PaymentMethodTranslation:
     tpay_payment_method_translation:
@@ -108,3 +124,8 @@ Sylius\Component\Payment\Model\PaymentMethodTranslation:
         locale: 'en_US'
         description: '<paragraph(2)>'
         translatable: '@tpay_pbl'
+    tpay_visa_mobile_payment_method_translation:
+        name: 'Visa mobile (Tpay)'
+        locale: 'en_US'
+        description: '<paragraph(2)>'
+        translatable: '@tpay_visa_mobile'