Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to retry a pbl payment #100

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

arti0090
Copy link
Contributor

@arti0090 arti0090 commented Oct 18, 2024

Closes #71

Adds coverage for #96 🚀

@arti0090 arti0090 linked an issue Oct 18, 2024 that may be closed by this pull request
@arti0090 arti0090 marked this pull request as ready for review October 18, 2024 18:45
@arti0090 arti0090 force-pushed the 71-support-retrying-a-pay-by-link-payment branch from 8093eec to b023f51 Compare October 21, 2024 12:54
@arti0090 arti0090 force-pushed the 71-support-retrying-a-pay-by-link-payment branch from b023f51 to bdae536 Compare October 21, 2024 12:59
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code wise 👍

tests/E2E/Order/TpayRetryOrChangePaymentOrderTest.php Outdated Show resolved Hide resolved
config/config/sylius_template_events.php Outdated Show resolved Hide resolved
@jakubtobiasz
Copy link
Member

I might be wrong or the sandbox is working in an unexpected way, but after paying with Tpay (I returned to the shop by hand) and trying to pay agin with PBL ING I'm redirected to Tpay's regular payment page, not directly to selecting the payment success/failure buttons.

@lchrusciel
Copy link
Member

I can confirm, it does not work as expected

@jakubtobiasz
Copy link
Member

I can confirm it works after the latest fix.

@jakubtobiasz jakubtobiasz merged commit 6f3ef5b into main Oct 22, 2024
4 checks passed
@jakubtobiasz jakubtobiasz deleted the 71-support-retrying-a-pay-by-link-payment branch October 22, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support retrying a Pay by link payment
3 participants