Handle Blik Level 0 payments #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jakubtobiasz
reviewed
Sep 5, 2024
arti0090
force-pushed
the
6-implement-handling-blik-level-0
branch
from
ff36684 to
4c2868a
Compare
arti0090
force-pushed
the
6-implement-handling-blik-level-0
branch
from
6995cbd to
3cffa46
Compare
arti0090
force-pushed
the
6-implement-handling-blik-level-0
branch
from
3cffa46 to
ddf63ec
Compare
arti0090
changed the title
arti0090
force-pushed
the
6-implement-handling-blik-level-0
branch
from
26475bf to
914043f
Compare
arti0090
force-pushed
the
6-implement-handling-blik-level-0
branch
from
914043f to
69bc7fd
Compare
|
Missing points:
|
jakubtobiasz
approved these changes
Sep 11, 2024
|
I'll make a separate task to cover non happy path cases. |
jakubtobiasz
changed the title
1 task
lchrusciel
reviewed
Sep 12, 2024
| 'sylius.shop.checkout.complete.summary' => [ | ||
| 'blocks' => [ | ||
| 'blik' => [ | ||
| 'template' => '@CommerceWeaversSyliusTpayPlugin/blik.html.twig', |
There was a problem hiding this comment.
Templates like that should be rather placed in some subfolder. Shop prefix should be placed at least
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| namespace Symfony\Component\DependencyInjection\Loader\Configurator; | |||
|
|
|||
| use CommerceWeavers\SyliusTpayPlugin\Payum\Action\Api\CreateBlik0TransactionAction; | |||
There was a problem hiding this comment.
Let's adjust naming to @coldic3 suggestion
Suggested change
| use CommerceWeavers\SyliusTpayPlugin\Payum\Action\Api\CreateBlik0TransactionAction; | |
| use CommerceWeavers\SyliusTpayPlugin\Payum\Action\Api\CreateBlikLevelZeroTransactionAction; |
if @jakubtobiasz is fine with that
| @@ -20,6 +21,7 @@ | |||
| $services->set(CaptureAction::class) | |||
| ->args([ | |||
| service('commerce_weavers.tpay.payum.factory.create_transaction'), | |||
| service('commerce_weavers.tpay.payum.factory.create_blik0_transaction'), | |||
There was a problem hiding this comment.
or at least we can adjust service names
Suggested change
| service('commerce_weavers.tpay.payum.factory.create_blik0_transaction'), | |
| service('commerce_weavers.tpay.payum.factory.create_blik_level_zero_transaction'), |
| @@ -28,4 +29,8 @@ | |||
| $services->set('commerce_weavers.tpay.payum.factory.create_transaction', CreateTransactionFactory::class) | |||
| ->alias(CreateTransactionFactoryInterface::class, 'commerce_weavers.tpay.payum.factory.create_transaction') | |||
| ; | |||
|
|
|||
| $services->set('commerce_weavers.tpay.payum.factory.create_blik0_transaction', CreateBlik0TransactionFactory::class) | |||
| ->alias(CreateTransactionFactoryInterface::class, 'commerce_weavers.tpay.payum.factory.create_blik0_transaction') | |||
|
|
||
| trait OrderLastNewPaymentAwareTrait | ||
| { | ||
| public function getLastNewPayment(): ?PaymentInterface |
There was a problem hiding this comment.
Misleading naming. Payment on its own has new state and according to name I would expect such a payment.
Suggested change
| public function getLastNewPayment(): ?PaymentInterface | |
| public function getLastCartPayment(): ?PaymentInterface |
class name should be changed as well
| { | ||
| $builder->add('others', PaymentDetailsType::class, [ | ||
| 'label' => 'commerce_weavers_sylius_tpay.payment.blik.token', | ||
| // TODO some validation that works becuase this kind does not |
There was a problem hiding this comment.
No todos nor comments should be committed to the codebase. You are more than welcome to open an issue and add it to board
| @@ -29,6 +30,14 @@ public function execute($request): void | |||
| /** @var PaymentInterface $model */ | |||
| $model = $request->getModel(); | |||
|
|
|||
| if ($this->transactionIsBlik($model)) { | |||
There was a problem hiding this comment.
C'mon, it is widely accepted practice to put is and other verbs at the beginning of functions, please adjust code to informal standard
Suggested change
| if ($this->transactionIsBlik($model)) { | |
| if ($this->isBlikTransaction($model)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6