Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change resolved banks on pbl payments #140

Merged
merged 6 commits into from
Oct 31, 2024
Merged

Change resolved banks on pbl payments #140

merged 6 commits into from
Oct 31, 2024

Conversation

arti0090
Copy link
Contributor

@arti0090 arti0090 commented Oct 30, 2024 •
edited
Loading

Left TODO:

  • Check the payment methods to see if they are enabled at the moment (for valid channel list)
  • Payments different than banks do not work on vendor level (attached screenshot), maybe it is sandbox api issue?
    Zrzut ekranu 2024-10-30 o 12 33 46

note to 2nd todo: partialy works, some instalments do work some not but it is coming from tpay API not from plugin

@arti0090 arti0090 linked an issue Oct 30, 2024 that may be closed by this pull request
Change resolved banks on PBL payments #117
Closed
@arti0090 arti0090 marked this pull request as draft October 30, 2024 12:05
@arti0090 arti0090 force-pushed the 117-change-resolved-banks-on-pbl-payments branch from 55a473e to 9a96ab2 Compare October 30, 2024 12:12
@arti0090 arti0090 marked this pull request as ready for review October 30, 2024 16:47
lchrusciel
lchrusciel previously approved these changes Oct 30, 2024
View reviewed changes
config/config/sylius_fixtures.php Outdated Show resolved Hide resolved
src/Tpay/Provider/ValidTpayChannelListProvider.php Outdated Show resolved Hide resolved
@lchrusciel lchrusciel dismissed their stale review October 30, 2024 17:41

Manual tests failed

@arti0090 arti0090 force-pushed the 117-change-resolved-banks-on-pbl-payments branch from c88bfbe to 0a9b148 Compare October 31, 2024 11:18
@lchrusciel lchrusciel force-pushed the 117-change-resolved-banks-on-pbl-payments branch from 0a9b148 to f1a5168 Compare October 31, 2024 12:44
@lchrusciel lchrusciel force-pushed the 117-change-resolved-banks-on-pbl-payments branch from 2d659be to 5d66098 Compare October 31, 2024 13:30
@lchrusciel lchrusciel force-pushed the 117-change-resolved-banks-on-pbl-payments branch from 5d66098 to e5866db Compare October 31, 2024 13:40
@lchrusciel lchrusciel merged commit 5347811 into main Oct 31, 2024
3 of 4 checks passed
@lchrusciel lchrusciel deleted the 117-change-resolved-banks-on-pbl-payments branch October 31, 2024 14:38
@lchrusciel lchrusciel restored the 117-change-resolved-banks-on-pbl-payments branch November 14, 2024 17:56
@lchrusciel lchrusciel deleted the 117-change-resolved-banks-on-pbl-payments branch November 14, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coldic3 coldic3 coldic3 left review comments

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change resolved banks on PBL payments
3 participants
@arti0090 @lchrusciel @coldic3