Revive CI #15
Merged
Revive CI #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubtobiasz
force-pushed
the
11-revive-ci
branch
10 times, most recently
from
aced534 to
0c6fcd9
Compare
jakubtobiasz
force-pushed
the
11-revive-ci
branch
from
0c6fcd9 to
b97a926
Compare
jakubtobiasz
force-pushed
the
11-revive-ci
branch
from
46195b0 to
424b58b
Compare
jakubtobiasz
commented
Sep 5, 2024
Comment on lines
+61
to
+63
| - name: Check dependencies | ||
| continue-on-error: true | ||
| run: vendor/bin/composer-dependency-analyser |
There was a problem hiding this comment.
I've already spent too much time on figuring out why the configuration wasn't working, so I'm skipping it for now. In general, as we install all deps we're getting false-positives. We need to extract it to a separate job, download only non-dev deps, and then run it.
jakubtobiasz
commented
Sep 5, 2024
Comment on lines
+12
to
+13
| ->ignoreErrorsOnPackage('sylius/sylius', [ErrorType::DEV_DEPENDENCY_IN_PROD]) | ||
| ->ignoreErrorsOnPackage('sylius/core-bundle', [ErrorType::UNUSED_DEPENDENCY]) |
There was a problem hiding this comment.
For the same reason as mentioned in ci.yaml; it should be removed once fixed there;
jakubtobiasz
commented
Sep 5, 2024
| @@ -5,8 +5,7 @@ | |||
| "license": "MIT", | |||
| "autoload": { | |||
| "psr-4": { | |||
| "CommerceWeavers\\SyliusTpayPlugin\\": "src/", | |||
| "Tests\\CommerceWeavers\\SyliusTpayPlugin\\Behat\\": "tests/Behat" | |||
jakubtobiasz
commented
Sep 5, 2024
|
|
||
| final class CommerceWeaversSyliusTpayPlugin extends AbstractBundle |
There was a problem hiding this comment.
It wasn't present in Symfony 5.4 :<
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11