Fixes to install and run the plugin with Sylius Standard #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldic3
commented
Nov 4, 2024
coldic3
force-pushed
the
fix/necessary-fixes-to-install-and-run-plugin-with-sylius-standard
branch
from
bf5631b to
58ac9c5
Compare
lchrusciel
approved these changes
Nov 4, 2024
| use CommerceWeavers\SyliusTpayPlugin\Tpay\PayGroup; | ||
| use CommerceWeavers\SyliusTpayPlugin\Tpay\PaymentType; | ||
| use Payum\Core\Security\CryptedInterface; | ||
| use Payum\Core\Security\CypherInterface; | ||
| use Sylius\Bundle\PayumBundle\Model\GatewayConfigInterface; | ||
| use Sylius\Component\Channel\Context\ChannelContextInterface; | ||
| use Sylius\Component\Core\Model\PaymentMethodInterface; | ||
| use Sylius\Component\Core\Repository\PaymentMethodRepositoryInterface as BasePaymentMethodRepositoryInterface; |
There was a problem hiding this comment.
do we need this typhint if CommerceWeavers\SyliusTpayPlugin\Repository\PaymentMethodRepositoryInterface already extends it?
lchrusciel
deleted the
fix/necessary-fixes-to-install-and-run-plugin-with-sylius-standard
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #168, #8