Allow paying with using on-site credit card

[jakubtobiasz]

closes #21

[jakubtobiasz]

To be checked: make sure it handles all possible cases
Improvement: we might introduce ->isFailed() or isRequiring3DS() to make it cleaner;

[coldic3]

Suggested change

	[$this->removeUnnecessaryPaymentDetailsFieldsListener, '__invoke'],
	[$this->removeUnnecessaryPaymentDetailsFieldsListener],

Will it also work like this?

[coldic3]

It's totally fine now, but I'd like to share an idea to follow AAA pattern. All "should" methods we could move at the end. WDYT?

Suggested change

	$form = $this->prophesize(FormInterface::class);
	$form->remove('card')->shouldBeCalled()->willReturn($form);
	$form->remove('blik_token')->shouldNotBeCalled();
	$event = new FormEvent($form->reveal(), ['blik_token' => '123456']);
	$this->createTestSubject()->__invoke($event);
	$form = $this->prophesize(FormInterface::class);
	$form->remove('card')->willReturn($form);
	$event = new FormEvent($form->reveal(), ['blik_token' => '123456']);
	$this->createTestSubject()->__invoke($event);
	$form->remove('card)->shouldBeCalled();
	$form->remove('blik_token')->shouldNotBeCalled();

[coldic3]

    $choices = [];

    foreach (['january, 'february', '...', 'december'] as $key => $month) {
        $choices[sprintf('commerce_weavers_sylius_tpay.shop.order_summary.card.expiration_date.month.%s', $month)] = sprintf("%02d", $key + 1)
    }

WDYT?

[lchrusciel]

Can't we rather base our decision on the state of the payment itself? Only when given payment method will be selected, then we are adding given fields

[jakubtobiasz]

I think this solutions is enough. We base the decision about passed data on a type defined in the gateway (see my screenshot two comments below). Here we only check whether a some data is passed (template is no loaded = field is not shown = we're getting a null); so we just remove it to avoid 500.

[lchrusciel]

how will we decide in UI which option will be used?

[jakubtobiasz]

In the Admin Panel we can choose a Tpay payment type:

And in the UI we just check this value:

[jakubtobiasz]

At the same time, I believe this type should be a value on payment details, so it can be easily accessed e.g. in the Payum action, so instead this if statement you marked, we'll do something like this:

return $details['tpay']['type'] === 'redirect';

Thanks to this change, once a new method is added, it's not required to modify the CreateRedirectBasedTransactionAction class.